fix(platform-server): remove peer dependency on animations#58997
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(platform-server): remove peer dependency on animations#58997crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
Contributor
|
Nit: might also be worth removing https://github.com/angular/angular/blob/37b6bd5addfbdd9949dfbec825c2c8203d2a076d/packages/platform-server/BUILD.bazel#L18 |
The `@angular/platform-server` package had a peer dependency on `@angular/animations` which wasn't being used anywhere.
37b6bd5 to
b491f3f
Compare
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Dec 2, 2024
The `@angular/platform-server` package had a peer dependency on `@angular/animations` which wasn't being used anywhere. PR Close #58997
Member
|
This PR was merged into the repository by commit 1cfbfc6. The changes were merged into the following branches: main, 19.0.x |
|
Now, we are getting: Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@angular/animations' imported from C:\Users...\node_modules@angular\platform-browser\fesm2022\animations.mjs |
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this pull request
Dec 4, 2024
…ngular#58997)" This reverts commit 1cfbfc6.
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Dec 4, 2024
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Dec 4, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…8997) The `@angular/platform-server` package had a peer dependency on `@angular/animations` which wasn't being used anywhere. PR Close angular#58997
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@angular/platform-serverpackage had a peer dependency on@angular/animationswhich wasn't being used anywhere.