refactor(core): test EventEmitter completion on destroy with outputToObservable#58239
Closed
cexbrayat wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): test EventEmitter completion on destroy with outputToObservable#58239cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat wants to merge 1 commit intoangular:mainfrom
Conversation
…Observable A unit test has been added to check that `EventEmitter` properly completes upon component/directive destrouction when used with `outputToObservable`. It explains why `destroyRef` has to be injected in `EventEmitter` in the first place.
Member
|
This PR was merged into the repository by commit a8d4eb8. The changes were merged into the following branches: main, 18.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
A unit test has been added to check that
EventEmitterproperly completes upon component/directive destrouction when used withoutputToObservable. It explains whydestroyRefhas to be injected inEventEmitterin the first place.This is a follow-up to #58219 With this test, the PR would have failed.
Does this PR introduce a breaking change?
Other information