Requesting a review from Paul who introduced it in #54650. (866271a)

Removing destroyRef here is unintended because the destroyRef is intentionally exposed for automatic clean-up when event emitters, or output refs are used in outputToObservable.

It's optional for cases where EventEmitter is created outside of injection contexts.

As @devversion says, this is required for outputToObservable to work correctly. EventEmitter should only be used for @Outputs, where injection context is available, so injecting DestroyRef is not an issue.

@devversion @alxhub Ok thanks 👍 But is it normal that no test fail when the injection is removed then?

@cexbrayat we should have one. I do see a few for clean-up tests for outputToObserverable, but could be possible that we are missing one for EventEmitter. I briefly remember one, but not sure where. Definitely feel free to add a test. that would be great

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}