Closed
Conversation
…l queries Adds initial migration logic to convert decorator query declarations to signal queries. We will re-use more part of the signal input migration in follow-ups, to properly migrate, and e.g. even handle control flow
Properly handles queries with multiple results, by extracting the type from the `QueryList`. Also adds more tests and handles imports.
…o signal queries Fix incorrect ID description
crisbeto
approved these changes
Aug 28, 2024
| const call = ts.factory.createCallExpression(newQueryFn, type ? [type] : undefined, args); | ||
| const updated = ts.factory.updatePropertyDeclaration( | ||
| node, | ||
| [ts.factory.createModifier(ts.SyntaxKind.ReadonlyKeyword)], |
There was a problem hiding this comment.
Wouldn't this remove existing visibility modifiers? Are there modifiers that we should preserve (ex.: visibility ones?)
Member
Author
There was a problem hiding this comment.
Yeah, this is just the initial migration code. This is not yet done.
Member
|
This PR was merged into the repository by commit c468198. The changes were merged into the following branches: main, 18.2.x |
alxhub
pushed a commit
that referenced
this pull request
Aug 28, 2024
Properly handles queries with multiple results, by extracting the type from the `QueryList`. Also adds more tests and handles imports. PR Close #57556
alxhub
pushed a commit
that referenced
this pull request
Aug 28, 2024
Properly handles queries with multiple results, by extracting the type from the `QueryList`. Also adds more tests and handles imports. PR Close #57556
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmit of #57525