refactor(migrations): initial migration logic for converting to signal queries#57525
Closed
devversion wants to merge 3 commits intoangular:mainfrom
Closed
refactor(migrations): initial migration logic for converting to signal queries#57525devversion wants to merge 3 commits intoangular:mainfrom
devversion wants to merge 3 commits intoangular:mainfrom
Conversation
…l queries Adds initial migration logic to convert decorator query declarations to signal queries. We will re-use more part of the signal input migration in follow-ups, to properly migrate, and e.g. even handle control flow
crisbeto
approved these changes
Aug 27, 2024
packages/core/schematics/migrations/signal-queries-migration/convert_query_property.ts
Show resolved
Hide resolved
Properly handles queries with multiple results, by extracting the type from the `QueryList`. Also adds more tests and handles imports.
packages/core/schematics/migrations/signal-queries-migration/identify_queries.ts
Outdated
Show resolved
Hide resolved
…o signal queries Fix incorrect ID description
Member
|
This PR was merged into the repository by commit f454ad3. The changes were merged into the following branches: main, 18.2.x |
alxhub
pushed a commit
that referenced
this pull request
Aug 27, 2024
Properly handles queries with multiple results, by extracting the type from the `QueryList`. Also adds more tests and handles imports. PR Close #57525
alxhub
pushed a commit
that referenced
this pull request
Aug 27, 2024
Properly handles queries with multiple results, by extracting the type from the `QueryList`. Also adds more tests and handles imports. PR Close #57525
alxhub
added a commit
to alxhub/angular
that referenced
this pull request
Aug 27, 2024
…ngular#57525)" This reverts commit f454ad3. Reason: breaks g3
alxhub
added a commit
to alxhub/angular
that referenced
this pull request
Aug 27, 2024
…to signal queries (angular#57525)" This reverts commit 6f5b435. Reason: breaks g3
alxhub
added a commit
that referenced
this pull request
Aug 27, 2024
alxhub
added a commit
that referenced
this pull request
Aug 27, 2024
alxhub
added a commit
that referenced
this pull request
Aug 27, 2024
alxhub
added a commit
that referenced
this pull request
Aug 27, 2024
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds initial migration logic to convert decorator query declarations to signal queries.
We will re-use more part of the signal input migration in follow-ups, to properly migrate,
and e.g. even handle control flow