Skip to content

Revert "refactor(core): Use ActionResolver in Dispatcher. (#56369)" #56440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AndrewKushnir wants to merge 1 commit into from
Closed

Revert "refactor(core): Use ActionResolver in Dispatcher. (#56369)" #56440

AndrewKushnir wants to merge 1 commit into from

Conversation

@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Jun 13, 2024

This reverts commit 4ebd285.

Reason for rollback: the change breaks some g3 code.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release core: event dispatch labels Jun 13, 2024
@ngbot ngbot bot modified the milestone: Backlog Jun 13, 2024
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Jun 13, 2024
thePunderWoman
thePunderWoman approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-core, public-api, primitives

@pullapprove pullapprove bot requested a review from atscott June 13, 2024 18:49
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Jun 13, 2024

TESTED= Pure Rollback

@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Jun 13, 2024

TESTED=Already rolled back in g3 (via this CL).

@AndrewKushnir AndrewKushnir mentioned this pull request Jun 13, 2024
Closed
12 tasks
@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Jun 13, 2024

This PR was merged into the repository by commit fca5764.

The changes were merged into the following branches: main, 18.0.x

AndrewKushnir added a commit that referenced this pull request Jun 13, 2024
@AndrewKushnir
Revert "refactor(core): Use ActionResolver in Dispatcher. (#56369)…
a620231 
…" (#56440)

This reverts commit 4ebd285.

PR Close #56440
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 14, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@alxhub alxhub Awaiting requested review from alxhub

@csmick csmick Awaiting requested review from csmick

@pkozlowski-opensource pkozlowski-opensource Awaiting requested review from pkozlowski-opensource

@atscott atscott Awaiting requested review from atscott

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: event dispatch PullApprove: disable requires: TGP This PR requires a passing TGP before merging is allowed target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewKushnir @thePunderWoman