Skip to content

refactor(core): Use ActionResolver in Dispatcher. #56369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tbondwilkinson wants to merge 1 commit into from
Closed

refactor(core): Use ActionResolver in Dispatcher. #56369

tbondwilkinson wants to merge 1 commit into from

Conversation

@tbondwilkinson
Copy link
Contributor

@tbondwilkinson tbondwilkinson commented Jun 10, 2024

EventContract usages in Angular now use false for useActionResolver. Tests have been updated, with functionality that depends on ActionResolver moving to dispatcher_test.ts.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

@tbondwilkinson tbondwilkinson force-pushed the jsaction-action-resolver branch from b7fe319 to e4712ff Compare June 10, 2024 19:48
@tbondwilkinson
Copy link
Contributor Author

tbondwilkinson commented Jun 11, 2024

TESTED=TGP

@tbondwilkinson tbondwilkinson added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate core: event dispatch labels Jun 11, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 11, 2024
@tbondwilkinson tbondwilkinson added the requires: TGP This PR requires a passing TGP before merging is allowed label Jun 11, 2024
@tbondwilkinson tbondwilkinson marked this pull request as ready for review June 11, 2024 16:37
thePunderWoman
thePunderWoman approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: fw-core, primitives

thePunderWoman
thePunderWoman approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from alxhub June 11, 2024 16:47
AndrewKushnir
AndrewKushnir approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Jun 11, 2024
@tbondwilkinson tbondwilkinson added the action: merge The PR is ready for merge by the caretaker label Jun 12, 2024
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Jun 13, 2024

This PR was merged into the repository by commit 4ebd285.

The changes were merged into the following branches: main, 18.0.x

AndrewKushnir pushed a commit that referenced this pull request Jun 13, 2024
@tbondwilkinson @AndrewKushnir
refactor(core): Use ActionResolver in Dispatcher. (#56369)
247dce0 
`EventContract` usages in Angular now use `false` for
`useActionResolver`. Tests have been updated, with functionality that
depends on `ActionResolver` moving to dispatcher_test.ts.

PR Close #56369
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Jun 13, 2024 •
edited
Loading

Reopening this PR, since it caused some breakages in g3 and was rolled back. Revert PR: #56440.

@AndrewKushnir AndrewKushnir reopened this Jun 13, 2024
@AndrewKushnir AndrewKushnir removed the action: merge The PR is ready for merge by the caretaker label Jun 13, 2024
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Jun 13, 2024
@AndrewKushnir
Revert "refactor(core): Use ActionResolver in Dispatcher. (angula…
5e71fae 
…r#56369)"

This reverts commit 4ebd285.
AndrewKushnir added a commit that referenced this pull request Jun 13, 2024
@AndrewKushnir
Revert "refactor(core): Use ActionResolver in Dispatcher. (#56369)…
fca5764 
…" (#56440)

This reverts commit 4ebd285.

PR Close #56440
AndrewKushnir added a commit that referenced this pull request Jun 13, 2024
@AndrewKushnir
Revert "refactor(core): Use ActionResolver in Dispatcher. (#56369)…
a620231 
…" (#56440)

This reverts commit 4ebd285.

PR Close #56440
@tbondwilkinson tbondwilkinson force-pushed the jsaction-action-resolver branch from e4712ff to e81abdb Compare June 25, 2024 13:16
@tbondwilkinson
refactor(core): Use ActionResolver in Dispatcher. (angular#56369)
f71fab9 
`EventContract` usages in Angular now use `false` for
`useActionResolver`. Tests have been updated, with functionality that
depends on `ActionResolver` moving to dispatcher_test.ts.

PR Close angular#56369
@tbondwilkinson
Copy link
Contributor Author

tbondwilkinson commented Jun 25, 2024 •
edited
Loading

TESTED=TGP

@tbondwilkinson tbondwilkinson added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Jun 25, 2024
@dylhunn
Copy link
Contributor

dylhunn commented Jun 26, 2024

This PR was merged into the repository by commit 1d28fbb.

The changes were merged into the following branches: main, 18.0.x

dylhunn pushed a commit that referenced this pull request Jun 26, 2024
@tbondwilkinson @dylhunn
refactor(core): Use ActionResolver in Dispatcher. (#56369) (#56369)
26f97c0 
`EventContract` usages in Angular now use `false` for
`useActionResolver`. Tests have been updated, with functionality that
depends on `ActionResolver` moving to dispatcher_test.ts.

PR Close #56369

PR Close #56369
@dylhunn dylhunn closed this in 1d28fbb Jun 26, 2024
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 27, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@iteriani iteriani iteriani approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: event dispatch requires: TGP This PR requires a passing TGP before merging is allowed target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@tbondwilkinson @AndrewKushnir @dylhunn @thePunderWoman @iteriani