Skip to content

fix(core): skip defer timers on the server#55480

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:55475/defer-server-timer
Closed

fix(core): skip defer timers on the server#55480
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:55475/defer-server-timer

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 23, 2024

Adds a check that disables the timer scheduling for placeholder and loading blocks on the server since the underlying timer will delay the server response.

Fixes #55475.

@crisbeto
fix(core): skip defer timers on the server
5e6ecf7 
Adds a check that disables the timer scheduling for `placeholder` and `loading` blocks on the server since the underlying timer will delay the server response.

Fixes angular#55475.
@crisbeto crisbeto force-pushed the 55475/defer-server-timer branch from a38b3d7 to 5e6ecf7 Compare April 23, 2024 12:31
@crisbeto crisbeto requested a review from AndrewKushnir April 23, 2024 13:17
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Apr 23, 2024
@crisbeto crisbeto marked this pull request as ready for review April 23, 2024 13:17
@ngbot ngbot bot modified the milestone: Backlog Apr 23, 2024
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 23, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 23, 2024
@alxhub
Copy link
Member

alxhub commented Apr 23, 2024

This PR was merged into the repository by commit 5948193.

alxhub pushed a commit that referenced this pull request Apr 23, 2024
@crisbeto @alxhub
fix(core): skip defer timers on the server (#55480)
8979fba 
Adds a check that disables the timer scheduling for `placeholder` and `loading` blocks on the server since the underlying timer will delay the server response.

Fixes #55475.

PR Close #55480
@alxhub alxhub closed this in 5948193 Apr 23, 2024
@crisbeto crisbeto mentioned this pull request May 1, 2024
Closed
@JiM-99-dev JiM-99-dev mentioned this pull request May 19, 2024
Open
@jesperancinha jesperancinha mentioned this pull request May 20, 2024
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 24, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Bug in @placeholder block causing delay in server-side rendering

3 participants

@crisbeto @alxhub @AndrewKushnir