fix(core): skip defer timers on the server (#55480)

crisbeto · alxhub · commit 5948193e1368 · 2024-04-23T13:06:52.000-07:00
Adds a check that disables the timer scheduling for `placeholder` and `loading` blocks on the server since the underlying timer will delay the server response. Fixes #55475. PR Close #55480
diff --git a/packages/core/src/defer/instructions.ts b/packages/core/src/defer/instructions.ts
@@ -480,8 +480,10 @@ export function renderDeferBlockState(
 
   if (isValidStateChange(currentState, newState) &&
       isValidStateChange(lDetails[NEXT_DEFER_BLOCK_STATE] ?? -1, newState)) {
+    const injector = hostLView[INJECTOR]!;
     const tDetails = getTDeferBlockDetails(hostTView, tNode);
-    const needsScheduling = !skipTimerScheduling &&
+    // Skips scheduling on the server since it can delay the server response.
+    const needsScheduling = !skipTimerScheduling && isPlatformBrowser(injector) &&
         (getLoadingBlockAfter(tDetails) !== null ||
          getMinimumDurationForState(tDetails, DeferBlockState.Loading) !== null ||
          getMinimumDurationForState(tDetails, DeferBlockState.Placeholder));
diff --git a/packages/core/test/bundling/defer/bundle.golden_symbols.json b/packages/core/test/bundling/defer/bundle.golden_symbols.json
@@ -2096,6 +2096,9 @@
   {
     "name": "isNodeMatchingSelectorList"
   },
+  {
+    "name": "isPlatformBrowser"
+  },
   {
     "name": "isPlatformServer"
   },

Original file line number	Diff line number	Diff line change
`@@ -2096,6 +2096,9 @@`
`2096`	`2096`	`{`
`2097`	`2097`	`"name": "isNodeMatchingSelectorList"`
`2098`	`2098`	`},`
	`2099`	`+ {`
	`2100`	`+ "name": "isPlatformBrowser"`
	`2101`	`+ },`
`2099`	`2102`	`{`
`2100`	`2103`	`"name": "isPlatformServer"`
`2101`	`2104`	`},`