fix(common): invalid ImageKit quality parameter#55193
Closed
johnnygerard wants to merge 4 commits intoangular:mainfrom
johnnygerard:imagekit-loader
Closed
fix(common): invalid ImageKit quality parameter#55193johnnygerard wants to merge 4 commits intoangular:mainfrom johnnygerard:imagekit-loader
johnnygerard wants to merge 4 commits intoangular:mainfrom
johnnygerard:imagekit-loader
Conversation
The current quality parameter is ignored by ImageKit.
JeanMeche
reviewed
Apr 3, 2024
packages/common/src/directives/ng_optimized_image/image_loaders/imagekit_loader.ts
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
Apr 3, 2024
JeanMeche
approved these changes
Apr 3, 2024
Member
JeanMeche
left a comment
There was a problem hiding this comment.
LGTM
Thank you for catching the issue and providing a fix !
Contributor
Author
|
Thank you @JeanMeche for your assistance. This was my first non-trivial pull request to an open source repository. |
AndrewKushnir
approved these changes
Apr 4, 2024
thePunderWoman
pushed a commit
that referenced
this pull request
Apr 5, 2024
The current quality parameter is ignored by ImageKit. PR Close #55193
thePunderWoman
pushed a commit
that referenced
this pull request
Apr 5, 2024
thePunderWoman
pushed a commit
that referenced
this pull request
Apr 5, 2024
Contributor
|
This PR was merged into the repository by commit 58e2f47. |
iteriani
pushed a commit
to iteriani/angular
that referenced
this pull request
Apr 11, 2024
The current quality parameter is ignored by ImageKit. PR Close angular#55193
iteriani
pushed a commit
to iteriani/angular
that referenced
this pull request
Apr 11, 2024
For commit cd911a8 PR Close angular#55193
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #55192
What is the new behavior?
Placeholder URLs of this form:
https://ik.imagekit.io/demo/tr:w-30,q-20/medium_cafe_B1iTdD0C.jpg
Does this PR introduce a breaking change?
Other information