fix(common): invalid ImageKit quality parameter

johnnygerard · johnnygerard · commit cd911a80084f · 2024-04-03T15:24:15.000+02:00
The current quality parameter is ignored by ImageKit.
diff --git a/packages/common/src/directives/ng_optimized_image/image_loaders/imagekit_loader.ts b/packages/common/src/directives/ng_optimized_image/image_loaders/imagekit_loader.ts
@@ -45,20 +45,22 @@ export function createImagekitUrl(path: string, config: ImageLoaderConfig): stri
   // Example of an ImageKit image URL:
   // https://ik.imagekit.io/demo/tr:w-300,h-300/medium_cafe_B1iTdD0C.jpg
   const {src, width} = config;
-  let urlSegments: string[];
+  const urlSegments: string[] = [path, src];
+  const params: string[] = [];
 
   if (width) {
-    const params = `tr:w-${width}`;
-    urlSegments = [path, params, src];
-  } else {
-    urlSegments = [path, src];
+    params.push(`w-${width}`);
   }
 
-  const url = new URL(urlSegments.join('/'));
-
   // When requesting a placeholder image we ask for a low quality image to reduce the load time.
   if (config.isPlaceholder) {
-    url.searchParams.set('q', PLACEHOLDER_QUALITY);
+    params.push(`q-${PLACEHOLDER_QUALITY}`);
+  }
+
+  if (params.length) {
+    urlSegments.splice(1, 0, `tr:${params.join(',')}`);
   }
+
+  const url = new URL(urlSegments.join('/'));
   return url.href;
 }
