Skip to content

fix(http): manage different body types for caching POST requests#54980

Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:cache-http-key
Closed

fix(http): manage different body types for caching POST requests#54980
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:cache-http-key

Conversation

@alan-agius4
Copy link
Contributor

This update enhances the encoding handling of request bodies to generate the necessary cache key for transfer cache functionality.

Closes #54956

@alan-agius4 alan-agius4 added area: common/http Issues related to HTTP and HTTP Client target: patch This PR is targeted for the next patch release server: http cache labels Mar 21, 2024
@ngbot ngbot bot modified the milestone: Backlog Mar 21, 2024
@alan-agius4 alan-agius4 marked this pull request as ready for review March 21, 2024 14:16
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 21, 2024
This update enhances the encoding handling of request bodies to generate the necessary cache key for transfer cache functionality.

Closes angular#54956
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 23, 2024
@dylhunn
Copy link
Contributor

dylhunn commented Mar 25, 2024

This PR was merged into the repository by commit 13554f9.

dylhunn pushed a commit that referenced this pull request Mar 25, 2024
)

This update enhances the encoding handling of request bodies to generate the necessary cache key for transfer cache functionality.

Closes #54956

PR Close #54980
@dylhunn dylhunn closed this in 13554f9 Mar 25, 2024
@alan-agius4 alan-agius4 deleted the cache-http-key branch March 25, 2024 18:21
Jefftopia added a commit to Jefftopia/angular that referenced this pull request Mar 26, 2024
transfer cache interceptor should not run again on the client as it is intended for server to client handoff

Squashed commit of the following:

commit 0dbeb446721796e6eb1979264e0caf1972b40187
Merge: a8d132a ee3bb81
Author: Jeffrey Smith <jsmith6690@gmail.com>
Date:   Mon Mar 25 17:51:23 2024 -0400

    Merge branch 'main' of https://github.com/angular/angular into feat/skip-transfer-cache-browser

commit ee3bb81
Author: Matthieu Riegler <kyro38@gmail.com>
Date:   Fri Mar 15 21:27:55 2024 +0100

    refactor(common): request low quality placeholder images (angular#54899)

    For every built-in load, this commit adds a parameter to load low quality placeholder images. Using 20/100 as base value.

    PR Close angular#54899

commit 13554f9
Author: Alan Agius <alanagius@google.com>
Date:   Thu Mar 21 14:17:03 2024 +0000

    fix(http): manage different body types for caching POST requests (angular#54980)

    This update enhances the encoding handling of request bodies to generate the necessary cache key for transfer cache functionality.

    Closes angular#54956

    PR Close angular#54980

commit b2ba945
Author: Matthieu Riegler <kyro38@gmail.com>
Date:   Sat Mar 23 23:30:54 2024 -0700

    docs: unescape html entities (angular#55016)

    adev supports regular characters in place of entity. Let's use them to make the ease the work for the editors.

    PR Close angular#55016

commit 9dabef0
Author: Andrea Canciani <ranma42@gmail.com>
Date:   Sun Mar 24 10:38:34 2024 +0100

    test(zone.js): fix zone.js test listener removal (angular#55017)

    The test was checking the wrong set of listeners because of a typo.

    PR Close angular#55017

commit 6f8b48a
Author: Jeffrey Smith <jsmith6690@gmail.com>
Date:   Sat Mar 23 12:29:41 2024 -0400

    feat(common): skip transfer cache on client

    transfer cache interceptor should not run again on the client as it is intended for server to client handoff
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client server: http cache target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In SSR mode the HTTP POST cache should consider cases when the body is an object

3 participants