refactor(common): request low quality placeholder images#54899
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
refactor(common): request low quality placeholder images#54899JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
kara
approved these changes
Mar 22, 2024
Contributor
kara
left a comment
There was a problem hiding this comment.
LGTM, just some typos to fix in comments
packages/common/src/directives/ng_optimized_image/image_loaders/cloudflare_loader.ts
Outdated
Show resolved
Hide resolved
packages/common/src/directives/ng_optimized_image/image_loaders/imagekit_loader.ts
Outdated
Show resolved
Hide resolved
packages/common/src/directives/ng_optimized_image/image_loaders/netlify_loader.ts
Outdated
Show resolved
Hide resolved
kara
reviewed
Mar 22, 2024
packages/common/src/directives/ng_optimized_image/image_loaders/cloudflare_loader.ts
Outdated
Show resolved
Hide resolved
19fd9d7 to
e1a5995
Compare
AndrewKushnir
approved these changes
Mar 23, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Looks great, just added a couple minor comments.
packages/common/src/directives/ng_optimized_image/image_loaders/netlify_loader.ts
Outdated
Show resolved
Hide resolved
packages/common/src/directives/ng_optimized_image/image_loaders/constants.ts
Outdated
Show resolved
Hide resolved
For every built-in load, this commit adds a parameter to load low quality placeholder images. Using 20/100 as base value.
e1a5995 to
743cc35
Compare
AndrewKushnir
approved these changes
Mar 23, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@JeanMeche thanks for addressing the feedback 👍
Contributor
Contributor
|
This PR was merged into the repository by commit ee3bb81. |
dylhunn
pushed a commit
that referenced
this pull request
Mar 25, 2024
For every built-in load, this commit adds a parameter to load low quality placeholder images. Using 20/100 as base value. PR Close #54899
Jefftopia
added a commit
to Jefftopia/angular
that referenced
this pull request
Mar 26, 2024
transfer cache interceptor should not run again on the client as it is intended for server to client handoff Squashed commit of the following: commit 0dbeb446721796e6eb1979264e0caf1972b40187 Merge: a8d132a ee3bb81 Author: Jeffrey Smith <jsmith6690@gmail.com> Date: Mon Mar 25 17:51:23 2024 -0400 Merge branch 'main' of https://github.com/angular/angular into feat/skip-transfer-cache-browser commit ee3bb81 Author: Matthieu Riegler <kyro38@gmail.com> Date: Fri Mar 15 21:27:55 2024 +0100 refactor(common): request low quality placeholder images (angular#54899) For every built-in load, this commit adds a parameter to load low quality placeholder images. Using 20/100 as base value. PR Close angular#54899 commit 13554f9 Author: Alan Agius <alanagius@google.com> Date: Thu Mar 21 14:17:03 2024 +0000 fix(http): manage different body types for caching POST requests (angular#54980) This update enhances the encoding handling of request bodies to generate the necessary cache key for transfer cache functionality. Closes angular#54956 PR Close angular#54980 commit b2ba945 Author: Matthieu Riegler <kyro38@gmail.com> Date: Sat Mar 23 23:30:54 2024 -0700 docs: unescape html entities (angular#55016) adev supports regular characters in place of entity. Let's use them to make the ease the work for the editors. PR Close angular#55016 commit 9dabef0 Author: Andrea Canciani <ranma42@gmail.com> Date: Sun Mar 24 10:38:34 2024 +0100 test(zone.js): fix zone.js test listener removal (angular#55017) The test was checking the wrong set of listeners because of a typo. PR Close angular#55017 commit 6f8b48a Author: Jeffrey Smith <jsmith6690@gmail.com> Date: Sat Mar 23 12:29:41 2024 -0400 feat(common): skip transfer cache on client transfer cache interceptor should not run again on the client as it is intended for server to client handoff
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For every built-in loader, this commit adds a parameter to load low quality placeholder images. Using 20/100 as base value.