[Cherry pick] build: reuse fake core in type checking tests (#54344)#54398
Closed
crisbeto wants to merge 1 commit intoangular:17.2.xfrom
Closed
[Cherry pick] build: reuse fake core in type checking tests (#54344)#54398crisbeto wants to merge 1 commit intoangular:17.2.xfrom
crisbeto wants to merge 1 commit intoangular:17.2.xfrom
Conversation
Currently we have two fake copies of `@angular/core` in the compiler tests which can be out of sync and cause inconsistent tests. These changes reuse a single copy instead. PR Close angular#54344
Member
Author
|
Disabling PullApprove since it's just a cherry-pick. |
AndrewKushnir
approved these changes
Feb 12, 2024
Contributor
|
This PR was merged into the repository by commit 277540c. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Feb 12, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picks #54344 into the RC branch.
Currently we have two fake copies of
@angular/corein the compiler tests which can be out of sync and cause inconsistent tests. These changes reuse a single copy instead.