build: reuse fake core in type checking tests#54344
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
build: reuse fake core in type checking tests#54344crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
devversion
approved these changes
Feb 8, 2024
Member
devversion
left a comment
There was a problem hiding this comment.
Nice nice! only one left 😄
Currently we have two fake copies of `@angular/core` in the compiler tests which can be out of sync and cause inconsistent tests. These changes reuse a single copy instead.
8a738ce to
2aa0b59
Compare
atscott
approved these changes
Feb 8, 2024
Contributor
|
This PR was merged into the repository by commit 153fc61. |
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Feb 12, 2024
Currently we have two fake copies of `@angular/core` in the compiler tests which can be out of sync and cause inconsistent tests. These changes reuse a single copy instead. PR Close angular#54344
AndrewKushnir
pushed a commit
that referenced
this pull request
Feb 12, 2024
atscott
pushed a commit
to atscott/angular
that referenced
this pull request
Feb 16, 2024
Currently we have two fake copies of `@angular/core` in the compiler tests which can be out of sync and cause inconsistent tests. These changes reuse a single copy instead. PR Close angular#54344
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have two fake copies of
@angular/corein the compiler tests which can be out of sync and cause inconsistent tests. These changes reuse a single copy instead.