fix(core): change defer block fixture default behavior to playthrough#54088
Closed
cexbrayat wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): change defer block fixture default behavior to playthrough#54088cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat wants to merge 1 commit intoangular:mainfrom
Conversation
63367e7 to
5a2c333
Compare
This is a followup to angular#53956 The default behavior needs to be changed in `TestBedCompiler` as well to have an effect.
5a2c333 to
49127fe
Compare
Contributor
|
I'm confused. We should have already changed this in #53956. Update: Ah I see. I missed the test bed compiler change. |
jessicajaniuk
approved these changes
Jan 26, 2024
| private testModuleRef: NgModuleRef<any>|null = null; | ||
|
|
||
| private deferBlockBehavior = DeferBlockBehavior.Manual; | ||
| private deferBlockBehavior = DEFER_BLOCK_DEFAULT_BEHAVIOR; |
Contributor
There was a problem hiding this comment.
Looks like this is what we missed. Thanks for catching this.
jessicajaniuk
pushed a commit
that referenced
this pull request
Jan 26, 2024
Contributor
|
This PR was merged into the repository by commit 037b79b. |
nikvarma
pushed a commit
to nikvarma/angular
that referenced
this pull request
Jan 31, 2024
…angular#54088) This is a followup to angular#53956 The default behavior needs to be changed in `TestBedCompiler` as well to have an effect. PR Close angular#54088
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This is a followup to #53956
I think the default behavior needs to be changed in
TestBedCompileras well to have an effect.I tested with v17.2.0-next.0, and the current default behavior is still
Manualunless I missed something.What is the new behavior?
The default behavior is now
PlaythroughDoes this PR introduce a breaking change?
Other information