fix(core): Change defer block fixture default behavior to playthrough#53956
Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): Change defer block fixture default behavior to playthrough#53956jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
Conversation
Contributor
|
Context: this change addresses issue #53686. |
e188de3 to
55ae25c
Compare
alxhub
approved these changes
Jan 17, 2024
AndrewKushnir
approved these changes
Jan 17, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
LGTM, just a couple minor comments.
This inverts the default behavior of test bed to use playthrough for defer blocks instead of manual. fixes: angular#53686
55ae25c to
3dd0761
Compare
AndrewKushnir
approved these changes
Jan 17, 2024
Contributor
Author
|
Caretaker: this is safe to merge. the G3 failure is unrelated. |
Contributor
|
This PR was merged into the repository by commit df6c205. |
dylhunn
pushed a commit
that referenced
this pull request
Jan 17, 2024
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…angular#53956) This inverts the default behavior of test bed to use playthrough for defer blocks instead of manual. fixes: angular#53686 PR Close angular#53956
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…angular#53956) This inverts the default behavior of test bed to use playthrough for defer blocks instead of manual. fixes: angular#53686 PR Close angular#53956
14 tasks
cexbrayat
added a commit
to cexbrayat/angular
that referenced
this pull request
Jan 26, 2024
This is a followup to angular#53956 The default behavior needs to be changed in `TestBedCompiler` as well to have an effect.
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…angular#53956) This inverts the default behavior of test bed to use playthrough for defer blocks instead of manual. fixes: angular#53686 PR Close angular#53956
jessicajaniuk
pushed a commit
that referenced
this pull request
Jan 26, 2024
jessicajaniuk
pushed a commit
that referenced
this pull request
Jan 26, 2024
nikvarma
pushed a commit
to nikvarma/angular
that referenced
this pull request
Jan 31, 2024
…angular#53956) This inverts the default behavior of test bed to use playthrough for defer blocks instead of manual. fixes: angular#53686 PR Close angular#53956
nikvarma
pushed a commit
to nikvarma/angular
that referenced
this pull request
Jan 31, 2024
…angular#54088) This is a followup to angular#53956 The default behavior needs to be changed in `TestBedCompiler` as well to have an effect. PR Close angular#54088
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This inverts the default behavior of test bed to use playthrough for defer blocks instead of manual.
fixes: #53686
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?