Skip to content

refactor(compiler): Support externally provided defer deps fns#54043

Closed
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:external-defer-deps
Closed

refactor(compiler): Support externally provided defer deps fns#54043
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:external-defer-deps

Conversation

@dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Jan 24, 2024

In #53591, Andrew added local compliation support for defer blocks. However, this requires the ability to emit pre-generated static defer deps functions. We now also support that feature in Template Pipeline.

@dylhunn dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler compiler: template pipeline labels Jan 24, 2024
@ngbot ngbot bot modified the milestone: Backlog Jan 24, 2024
@dylhunn dylhunn force-pushed the external-defer-deps branch from 88b42eb to dea7f6b Compare January 24, 2024 01:42
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 24, 2024
@dylhunn dylhunn removed the request for review from mmalerba January 24, 2024 17:44
@dylhunn dylhunn added action: rerun CI at HEAD and removed action: merge The PR is ready for merge by the caretaker labels Jan 24, 2024
@ngbot
Copy link

ngbot bot commented Jan 24, 2024

@dylhunn the CircleCI rerun you requested failed. See details below:

invalid json response body at https://circleci.com/api/v2/project/gh/angular/angular/pipeline?circle-token=0b8e85cdbc076b09bcd8a1f4f3d7c6b7eff2109e reason: Unexpected token I in JSON at position 0

@dylhunn dylhunn force-pushed the external-defer-deps branch 3 times, most recently from 574d005 to 0d68463 Compare January 24, 2024 18:14
In angular#53591, Andrew added local compliation support for defer blocks. However, this requires the ability to emit pre-generated static defer deps functions. We now also support that feature in Template Pipeline.
@dylhunn dylhunn force-pushed the external-defer-deps branch from 0d68463 to 878f4f9 Compare January 24, 2024 18:15
@dylhunn
Copy link
Contributor Author

dylhunn commented Jan 24, 2024

caretaker: g3 failures are flakes

@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 24, 2024
jessicajaniuk pushed a commit that referenced this pull request Jan 24, 2024
In #53591, Andrew added local compliation support for defer blocks. However, this requires the ability to emit pre-generated static defer deps functions. We now also support that feature in Template Pipeline.

PR Close #54043
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 0f5f45c.

rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
…ar#54043)

In angular#53591, Andrew added local compliation support for defer blocks. However, this requires the ability to emit pre-generated static defer deps functions. We now also support that feature in Template Pipeline.

PR Close angular#54043
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
…ar#54043)

In angular#53591, Andrew added local compliation support for defer blocks. However, this requires the ability to emit pre-generated static defer deps functions. We now also support that feature in Template Pipeline.

PR Close angular#54043
nikvarma pushed a commit to nikvarma/angular that referenced this pull request Jan 31, 2024
…ar#54043)

In angular#53591, Andrew added local compliation support for defer blocks. However, this requires the ability to emit pre-generated static defer deps functions. We now also support that feature in Template Pipeline.

PR Close angular#54043
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler compiler: template pipeline merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants