refactor(compiler): support local compilation for @defer blocks by AndrewKushnir · Pull Request #53591 · angular/angular

AndrewKushnir · 2023-12-15T20:23:59Z

This commit updates Angular compiler to support local compilation mode for @defer blocks.

In local compilation mode, compiler can only rely on the information present in a currently processed file. As a result, compiler can not detect which components/directives/pipes belong to a particular @defer block (because that requires selector matching and selector info from other files where those classes are defined) and thus which classes can be defer-loaded. Because of this, no dependency functions are being generated for @defer blocks in the local compilation mode.

Also, this commit brings extra configuration and logic to make @defer blocks compatible with more constrained local compilation mode internally.

Overall, this change does not affect the behavior and APIs of @defer blocks externally (outside of Google's codebase) when using regular (full) compilation mode.

Does this PR introduce a breaking change?

Yes
No

packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts

packages/compiler/src/render3/view/t2_binder.ts

packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts

AndrewKushnir · 2024-01-10T02:30:56Z

Presubmit + TGP.

This commit updates a few places to extract the logic into a separate functions which will be reused in a few places in followup commits.

This commit updates typechecker to store full Pipe metadata in internal data strctures, so that this information is available to more places in the code, which will be updated in a followup commit.

…ide a defer block This commit updates the logic to expose an internal API on the `R3BoundTarget` to check if an element belongs to any defer block.

…ps in `@defer` for local compilation mode This commit adds an internal config option to enforce explicit deps in `@defer` for local compilation mode.

…deps config This commit updates the `DeferredSymbolTracker` class to take info account the `onlyExplicitDeferDependencyImports` flag. The `DeferredSymbolTracker` class also exposes a new API to register import declarations as explicitly deferred, which will be used in followup commits.

This commit updates the logic to add support for internal `deferredImports` field in compiler.

…and `deferredImports` This commit updates the typechecker logic to prevent same deps in `imports` and `deferredImports`.

… compilation This commit updates the logic of the `TemplateDefinitionBuilder` to support local compilation and generate a single dependency function for all explicitly deferred deps within a component.

This commit adds tests to cover local compilation support for `@defer` blocks.

…ion (#53591) This commit adds tests to cover local compilation support for `@defer` blocks. PR Close #53591

…#53591) This commit updates a few places to extract the logic into a separate functions which will be reused in a few places in followup commits. PR Close #53591

…#53591) This commit updates typechecker to store full Pipe metadata in internal data strctures, so that this information is available to more places in the code, which will be updated in a followup commit. PR Close #53591

…ide a defer block (#53591) This commit updates the logic to expose an internal API on the `R3BoundTarget` to check if an element belongs to any defer block. PR Close #53591

…ps in `@defer` for local compilation mode (#53591) This commit adds an internal config option to enforce explicit deps in `@defer` for local compilation mode. PR Close #53591

…deps config (#53591) This commit updates the `DeferredSymbolTracker` class to take info account the `onlyExplicitDeferDependencyImports` flag. The `DeferredSymbolTracker` class also exposes a new API to register import declarations as explicitly deferred, which will be used in followup commits. PR Close #53591

…53591) This commit updates the logic to add support for internal `deferredImports` field in compiler. PR Close #53591

…and `deferredImports` (#53591) This commit updates the typechecker logic to prevent same deps in `imports` and `deferredImports`. PR Close #53591

… compilation (#53591) This commit updates the logic of the `TemplateDefinitionBuilder` to support local compilation and generate a single dependency function for all explicitly deferred deps within a component. PR Close #53591

…ion (#53591) This commit adds tests to cover local compilation support for `@defer` blocks. PR Close #53591

…angular#53591) This commit updates a few places to extract the logic into a separate functions which will be reused in a few places in followup commits. PR Close angular#53591

…angular#53591) This commit updates typechecker to store full Pipe metadata in internal data strctures, so that this information is available to more places in the code, which will be updated in a followup commit. PR Close angular#53591

…ide a defer block (angular#53591) This commit updates the logic to expose an internal API on the `R3BoundTarget` to check if an element belongs to any defer block. PR Close angular#53591

…ps in `@defer` for local compilation mode (angular#53591) This commit adds an internal config option to enforce explicit deps in `@defer` for local compilation mode. PR Close angular#53591

…deps config (angular#53591) This commit updates the `DeferredSymbolTracker` class to take info account the `onlyExplicitDeferDependencyImports` flag. The `DeferredSymbolTracker` class also exposes a new API to register import declarations as explicitly deferred, which will be used in followup commits. PR Close angular#53591

…ngular#53591) This commit updates the logic to add support for internal `deferredImports` field in compiler. PR Close angular#53591

…and `deferredImports` (angular#53591) This commit updates the typechecker logic to prevent same deps in `imports` and `deferredImports`. PR Close angular#53591

… compilation (angular#53591) This commit updates the logic of the `TemplateDefinitionBuilder` to support local compilation and generate a single dependency function for all explicitly deferred deps within a component. PR Close angular#53591

…ion (angular#53591) This commit adds tests to cover local compilation support for `@defer` blocks. PR Close angular#53591

In angular#53591, Andrew added local compliation support for defer blocks. However, this requires the ability to emit pre-generated static defer deps functions. We now also support that feature in Template Pipeline.

In #53591, Andrew added local compliation support for defer blocks. However, this requires the ability to emit pre-generated static defer deps functions. We now also support that feature in Template Pipeline. PR Close #54043

angular-automatic-lock-bot · 2024-02-10T00:08:46Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

AndrewKushnir requested a review from alxhub December 15, 2023 20:24

ngbot bot added this to the Backlog milestone Dec 15, 2023

pullapprove bot requested a review from josephperrott December 15, 2023 20:24

AndrewKushnir mentioned this pull request Dec 15, 2023

refactor(compiler): support local compilation for @defer blocks #53573

Closed

2 tasks

AndrewKushnir mentioned this pull request Jan 2, 2024

fix(compiler-cli): handle default imports in defer blocks #53695

Closed

AndrewKushnir force-pushed the defer_local_compilation_1 branch from 98906ee to 170527b Compare January 3, 2024 18:56

AndrewKushnir mentioned this pull request Jan 5, 2024

[Test-only] Local compilation mode changes #53802

Closed

AndrewKushnir force-pushed the defer_local_compilation_1 branch from 170527b to d53f5b9 Compare January 5, 2024 02:30

alxhub reviewed Jan 8, 2024

View reviewed changes

packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts Outdated Show resolved Hide resolved

alxhub reviewed Jan 8, 2024

View reviewed changes

packages/compiler/src/render3/view/t2_binder.ts Outdated Show resolved Hide resolved

alxhub reviewed Jan 8, 2024

View reviewed changes

packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts Outdated Show resolved Hide resolved

alxhub approved these changes Jan 8, 2024

View reviewed changes

AndrewKushnir force-pushed the defer_local_compilation_1 branch from d53f5b9 to faea33e Compare January 10, 2024 02:06

AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 10, 2024

AndrewKushnir added 9 commits January 10, 2024 08:26

refactor(compiler-cli): extract various logic into separate functions

0faee07

This commit updates a few places to extract the logic into a separate functions which will be reused in a few places in followup commits.

refactor(compiler-cli): store full Pipe metadata in typechecking code

b29bcd3

This commit updates typechecker to store full Pipe metadata in internal data strctures, so that this information is available to more places in the code, which will be updated in a followup commit.

refactor(compiler): add an internal API to check is an element is ins…

c4405dd

…ide a defer block This commit updates the logic to expose an internal API on the `R3BoundTarget` to check if an element belongs to any defer block.

refactor(compiler-cli): add an internal config to enforce explicit de…

dfd1821

…ps in `@defer` for local compilation mode This commit adds an internal config option to enforce explicit deps in `@defer` for local compilation mode.

refactor(compiler): add support for internal deferredImports field

13d2e9f

This commit updates the logic to add support for internal `deferredImports` field in compiler.

refactor(compiler-cli): add checks to prevent same deps in imports …

d65384d

…and `deferredImports` This commit updates the typechecker logic to prevent same deps in `imports` and `deferredImports`.

refactor(compiler): update TemplateDefinitionBuilder to support local…

ffce9ed

… compilation This commit updates the logic of the `TemplateDefinitionBuilder` to support local compilation and generate a single dependency function for all explicitly deferred deps within a component.

refactor(compiler-cli): add tests for defer blocks and local compilation

918b1e6

This commit adds tests to cover local compilation support for `@defer` blocks.

atscott pushed a commit that referenced this pull request Jan 10, 2024

refactor(compiler-cli): add tests for defer blocks and local compilat…

79fbc4e

…ion (#53591) This commit adds tests to cover local compilation support for `@defer` blocks. PR Close #53591

atscott pushed a commit that referenced this pull request Jan 10, 2024

refactor(compiler): add support for internal deferredImports field (#…

4c4fea1

…53591) This commit updates the logic to add support for internal `deferredImports` field in compiler. PR Close #53591

atscott pushed a commit that referenced this pull request Jan 10, 2024

refactor(compiler-cli): add tests for defer blocks and local compilat…

12f9ed0

…ion (#53591) This commit adds tests to cover local compilation support for `@defer` blocks. PR Close #53591

dylhunn mentioned this pull request Jan 24, 2024

refactor(compiler): Support externally provided defer deps fns #54043

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(compiler): support local compilation for @defer blocks#53591

refactor(compiler): support local compilation for @defer blocks#53591
AndrewKushnir wants to merge 9 commits intoangular:mainfrom
AndrewKushnir:defer_local_compilation_1

AndrewKushnir commented Dec 15, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir commented Jan 10, 2024 •

edited

Loading

Uh oh!

angular-automatic-lock-bot bot commented Feb 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

AndrewKushnir commented Dec 15, 2023

Does this PR introduce a breaking change?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir commented Jan 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angular-automatic-lock-bot bot commented Feb 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AndrewKushnir commented Jan 10, 2024 •

edited

Loading