refactor(platform-browser): clean up legacy way of getting a relative path#53097
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
refactor(platform-browser): clean up legacy way of getting a relative path#53097crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
80575a4 to
614e91f
Compare
614e91f to
f2b618b
Compare
Member
Author
|
I'll TGP this tomorrow just in case. |
Member
Author
alan-agius4
reviewed
Nov 22, 2023
… path Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its `href` and reading the `pathname`. This is inefficient and it triggers an internal security check that doesn't allow the `href` attribute to be set which ends up blocking angular/components#28155. These changes switch to using the browser's built-in URL parsing instead.
f2b618b to
6d7a5d0
Compare
Member
Author
|
Second TGP. This one has a couple of failing targets, but they're broken in the same way at head so I doubt that it's related to my change. |
Member
|
This PR was merged into the repository by commit 162d940. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Nov 27, 2023
… path (#53097) Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its `href` and reading the `pathname`. This is inefficient and it triggers an internal security check that doesn't allow the `href` attribute to be set which ends up blocking angular/components#28155. These changes switch to using the browser's built-in URL parsing instead. PR Close #53097
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
… path (angular#53097) Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its `href` and reading the `pathname`. This is inefficient and it triggers an internal security check that doesn't allow the `href` attribute to be set which ends up blocking angular/components#28155. These changes switch to using the browser's built-in URL parsing instead. PR Close angular#53097
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
… path (angular#53097) Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its `href` and reading the `pathname`. This is inefficient and it triggers an internal security check that doesn't allow the `href` attribute to be set which ends up blocking angular/components#28155. These changes switch to using the browser's built-in URL parsing instead. PR Close angular#53097
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
… path (angular#53097) Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its `href` and reading the `pathname`. This is inefficient and it triggers an internal security check that doesn't allow the `href` attribute to be set which ends up blocking angular/components#28155. These changes switch to using the browser's built-in URL parsing instead. PR Close angular#53097
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its
hrefand reading thepathname. This is inefficient and it triggers an internal security check that doesn't allow thehrefattribute to be set which ends up blocking angular/components#28155.These changes switch to using the browser's built-in URL parsing instead.