refactor(platform-browser): clean up legacy way of getting a relative path (#53097)

crisbeto · pkozlowski-opensource · commit 162d940b7295 · 2023-11-27T10:59:53.000+01:00
Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its `href` and reading the `pathname`. This is inefficient and it triggers an internal security check that doesn't allow the `href` attribute to be set which ends up blocking angular/components#28155. These changes switch to using the browser's built-in URL parsing instead. PR Close #53097
diff --git a/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json b/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json
@@ -1454,9 +1454,6 @@
   {
     "name": "updateMicroTaskStatus"
   },
-  {
-    "name": "urlParsingNode"
-  },
   {
     "name": "viewAttachedToChangeDetector"
   },
diff --git a/packages/core/test/bundling/animations/bundle.golden_symbols.json b/packages/core/test/bundling/animations/bundle.golden_symbols.json
@@ -1526,9 +1526,6 @@
   {
     "name": "updateMicroTaskStatus"
   },
-  {
-    "name": "urlParsingNode"
-  },
   {
     "name": "viewAttachedToChangeDetector"
   },
diff --git a/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json b/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
@@ -1220,9 +1220,6 @@
   {
     "name": "updateMicroTaskStatus"
   },
-  {
-    "name": "urlParsingNode"
-  },
   {
     "name": "viewAttachedToChangeDetector"
   },
diff --git a/packages/core/test/bundling/defer/bundle.golden_symbols.json b/packages/core/test/bundling/defer/bundle.golden_symbols.json
@@ -2384,9 +2384,6 @@
   {
     "name": "updateMicroTaskStatus"
   },
-  {
-    "name": "urlParsingNode"
-  },
   {
     "name": "viewAttachedToChangeDetector"
   },
diff --git a/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json b/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json
@@ -1709,9 +1709,6 @@
   {
     "name": "updateMicroTaskStatus"
   },
-  {
-    "name": "urlParsingNode"
-  },
   {
     "name": "viewAttachedToChangeDetector"
   },
diff --git a/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json b/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json
@@ -1685,9 +1685,6 @@
   {
     "name": "updateMicroTaskStatus"
   },
-  {
-    "name": "urlParsingNode"
-  },
   {
     "name": "viewAttachedToChangeDetector"
   },
diff --git a/packages/core/test/bundling/hello_world/bundle.golden_symbols.json b/packages/core/test/bundling/hello_world/bundle.golden_symbols.json
@@ -971,9 +971,6 @@
   {
     "name": "updateMicroTaskStatus"
   },
-  {
-    "name": "urlParsingNode"
-  },
   {
     "name": "viewAttachedToChangeDetector"
   },
diff --git a/packages/core/test/bundling/hydration/bundle.golden_symbols.json b/packages/core/test/bundling/hydration/bundle.golden_symbols.json
@@ -1331,9 +1331,6 @@
   {
     "name": "updateMicroTaskStatus"
   },
-  {
-    "name": "urlParsingNode"
-  },
   {
     "name": "viewAttachedToChangeDetector"
   },
diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -2081,9 +2081,6 @@
   {
     "name": "updateSegmentGroupChildren"
   },
-  {
-    "name": "urlParsingNode"
-  },
   {
     "name": "viewAttachedToChangeDetector"
   },
diff --git a/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json b/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json
@@ -1073,9 +1073,6 @@
   {
     "name": "updateMicroTaskStatus"
   },
-  {
-    "name": "urlParsingNode"
-  },
   {
     "name": "viewAttachedToChangeDetector"
   },
diff --git a/packages/core/test/bundling/todo/bundle.golden_symbols.json b/packages/core/test/bundling/todo/bundle.golden_symbols.json
@@ -1472,9 +1472,6 @@
   {
     "name": "updateMicroTaskStatus"
   },
-  {
-    "name": "urlParsingNode"
-  },
   {
     "name": "viewAttachedToChangeDetector"
   },
diff --git a/packages/platform-browser/src/browser/browser_adapter.ts b/packages/platform-browser/src/browser/browser_adapter.ts
@@ -89,11 +89,8 @@ function getBaseElementHref(): string|null {
   return baseElement ? baseElement.getAttribute('href') : null;
 }
 
-// based on urlUtils.js in AngularJS 1
-let urlParsingNode: HTMLAnchorElement|undefined;
-function relativePath(url: any): string {
-  urlParsingNode = urlParsingNode || document.createElement('a');
-  urlParsingNode.setAttribute('href', url);
-  const pathName = urlParsingNode.pathname;
-  return pathName.charAt(0) === '/' ? pathName : `/${pathName}`;
+function relativePath(url: string): string {
+  // The base URL doesn't really matter, we just need it so relative paths have something
+  // to resolve against. In the browser `HTMLBaseElement.href` is always absolute.
+  return new URL(url, 'http://a').pathname;
 }

Original file line number	Diff line number	Diff line change
`@@ -1454,9 +1454,6 @@`
`1454`	`1454`	`{`
`1455`	`1455`	`"name": "updateMicroTaskStatus"`
`1456`	`1456`	`},`
`1457`		`- {`
`1458`		`- "name": "urlParsingNode"`
`1459`		`- },`
`1460`	`1457`	`{`
`1461`	`1458`	`"name": "viewAttachedToChangeDetector"`
`1462`	`1459`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1526,9 +1526,6 @@`
`1526`	`1526`	`{`
`1527`	`1527`	`"name": "updateMicroTaskStatus"`
`1528`	`1528`	`},`
`1529`		`- {`
`1530`		`- "name": "urlParsingNode"`
`1531`		`- },`
`1532`	`1529`	`{`
`1533`	`1530`	`"name": "viewAttachedToChangeDetector"`
`1534`	`1531`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1220,9 +1220,6 @@`
`1220`	`1220`	`{`
`1221`	`1221`	`"name": "updateMicroTaskStatus"`
`1222`	`1222`	`},`
`1223`		`- {`
`1224`		`- "name": "urlParsingNode"`
`1225`		`- },`
`1226`	`1223`	`{`
`1227`	`1224`	`"name": "viewAttachedToChangeDetector"`
`1228`	`1225`	`},`
Original file line number	Diff line number	Diff line change
`@@ -2384,9 +2384,6 @@`
`2384`	`2384`	`{`
`2385`	`2385`	`"name": "updateMicroTaskStatus"`
`2386`	`2386`	`},`
`2387`		`- {`
`2388`		`- "name": "urlParsingNode"`
`2389`		`- },`
`2390`	`2387`	`{`
`2391`	`2388`	`"name": "viewAttachedToChangeDetector"`
`2392`	`2389`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1709,9 +1709,6 @@`
`1709`	`1709`	`{`
`1710`	`1710`	`"name": "updateMicroTaskStatus"`
`1711`	`1711`	`},`
`1712`		`- {`
`1713`		`- "name": "urlParsingNode"`
`1714`		`- },`
`1715`	`1712`	`{`
`1716`	`1713`	`"name": "viewAttachedToChangeDetector"`
`1717`	`1714`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1685,9 +1685,6 @@`
`1685`	`1685`	`{`
`1686`	`1686`	`"name": "updateMicroTaskStatus"`
`1687`	`1687`	`},`
`1688`		`- {`
`1689`		`- "name": "urlParsingNode"`
`1690`		`- },`
`1691`	`1688`	`{`
`1692`	`1689`	`"name": "viewAttachedToChangeDetector"`
`1693`	`1690`	`},`
Original file line number	Diff line number	Diff line change
`@@ -971,9 +971,6 @@`
`971`	`971`	`{`
`972`	`972`	`"name": "updateMicroTaskStatus"`
`973`	`973`	`},`
`974`		`- {`
`975`		`- "name": "urlParsingNode"`
`976`		`- },`
`977`	`974`	`{`
`978`	`975`	`"name": "viewAttachedToChangeDetector"`
`979`	`976`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1331,9 +1331,6 @@`
`1331`	`1331`	`{`
`1332`	`1332`	`"name": "updateMicroTaskStatus"`
`1333`	`1333`	`},`
`1334`		`- {`
`1335`		`- "name": "urlParsingNode"`
`1336`		`- },`
`1337`	`1334`	`{`
`1338`	`1335`	`"name": "viewAttachedToChangeDetector"`
`1339`	`1336`	`},`
Original file line number	Diff line number	Diff line change
`@@ -2081,9 +2081,6 @@`
`2081`	`2081`	`{`
`2082`	`2082`	`"name": "updateSegmentGroupChildren"`
`2083`	`2083`	`},`
`2084`		`- {`
`2085`		`- "name": "urlParsingNode"`
`2086`		`- },`
`2087`	`2084`	`{`
`2088`	`2085`	`"name": "viewAttachedToChangeDetector"`
`2089`	`2086`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1073,9 +1073,6 @@`
`1073`	`1073`	`{`
`1074`	`1074`	`"name": "updateMicroTaskStatus"`
`1075`	`1075`	`},`
`1076`		`- {`
`1077`		`- "name": "urlParsingNode"`
`1078`		`- },`
`1079`	`1076`	`{`
`1080`	`1077`	`"name": "viewAttachedToChangeDetector"`
`1081`	`1078`	`},`