Skip to content

fix(migrations): Fixes control flow migration if then else case#53006

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:migration-thenfix
Closed

fix(migrations): Fixes control flow migration if then else case#53006
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:migration-thenfix

Conversation

@jessicajaniuk
Copy link
Copy Markdown
Contributor

With if then else use cases, we now properly account for the length of the original element's contents when tracking new offsets.

fixes: #52927

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Nov 17, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 17, 2023
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 17, 2023
With if then else use cases, we now properly account for the length
of the original element's contents when tracking new offsets.

fixes: angular#52927
@jessicajaniuk jessicajaniuk added the action: merge The PR is ready for merge by the caretaker label Nov 17, 2023
@AndrewKushnir
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 5564d02.

AndrewKushnir pushed a commit that referenced this pull request Nov 20, 2023
With if then else use cases, we now properly account for the length
of the original element's contents when tracking new offsets.

fixes: #52927

PR Close #53006
@jessicajaniuk jessicajaniuk deleted the migration-thenfix branch November 28, 2023 17:09
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…lar#53006)

With if then else use cases, we now properly account for the length
of the original element's contents when tracking new offsets.

fixes: angular#52927

PR Close angular#53006
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
…lar#53006)

With if then else use cases, we now properly account for the length
of the original element's contents when tracking new offsets.

fixes: angular#52927

PR Close angular#53006
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
…lar#53006)

With if then else use cases, we now properly account for the length
of the original element's contents when tracking new offsets.

fixes: angular#52927

PR Close angular#53006
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: 🐛 ng g @angular/core:control-flow schematic makes a lot of mistakes

3 participants