-
Notifications
You must be signed in to change notification settings - Fork 27.1k
fix: π ng g @angular/core:control-flow schematic makes a lot of mistakesΒ #52927
Copy link
Copy link
Closed
Labels
area: migrationsIssues related to `ng update`/`ng generate` migrationsIssues related to `ng update`/`ng generate` migrationscore: control flowIssues related to the built-in control flow (@if, @for, @switch)Issues related to the built-in control flow (@if, @for, @switch)
Milestone
Description
Which @angular/* package(s) are the source of the bug?
core
Is this a regression?
No
Description
Dear Team Angular π¦ΈββοΈ
Changing to control flow was the last step of our Angular 17 migration journey. It took us 2 days to migrate over to the "standalone way of doing things" in our 2000+ monorepo.
Once we ran the last schematic to introduce control flow, it changed 730 html files and the build failed.
We took a look at why it was failing. Attaching a zip ball that contains an advanced page and what it looked like before and after we applied the schematic. I recommend opening the files up with a diff tool.
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
Look at the errors in the attached zip.
Please provide the environment you discovered this bug in (run ng version)
Node : 20.9.0
OS : darwin-arm64
yarn : 1.22.19
@angular/core : 17.0.2
nx : 17.1.1
@nx/js : 17.1.1
@nx/jest : 17.1.1
@nx/linter : 17.1.1
@nx/eslint : 17.1.1
@nx/workspace : 17.1.1
@nx/angular : 17.1.1
@nx/cypress : 17.1.1
@nx/devkit : 17.1.1
@nx/eslint-plugin : 17.1.1
@nx/storybook : 17.1.1
@nrwl/tao : 17.1.1
@nx/web : 17.1.1
@nx/webpack : 17.1.1
typescript : 5.2.2
---------------------------------------
Community plugins:
@compodoc/compodoc : 1.1.22
@fortawesome/angular-fontawesome : 0.14.0
@jscutlery/semver : 4.0.0
@ng-bootstrap/ng-bootstrap : 15.1.2
@ngneat/transloco : 6.0.0
@ngrx/component : 16.3.0
@ngrx/component-store : 16.3.0
@ngrx/data : 16.3.0
@ngrx/effects : 16.3.0
@ngrx/entity : 16.3.0
@ngrx/router-store : 16.3.0
@ngrx/schematics : 16.3.0
@ngrx/store : 16.3.0
@ngrx/store-devtools : 16.3.0
@storybook/angular : 7.5.3
angular-calendar : 0.31.0
Anything else?
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area: migrationsIssues related to `ng update`/`ng generate` migrationsIssues related to `ng update`/`ng generate` migrationscore: control flowIssues related to the built-in control flow (@if, @for, @switch)Issues related to the built-in control flow (@if, @for, @switch)