Skip to content

fix NgModule compilation scope in deps tracker#51791

Closed
pmvald wants to merge 1 commit intoangular:mainfrom
pmvald:jit-fix-scope
Closed

fix NgModule compilation scope in deps tracker#51791
pmvald wants to merge 1 commit intoangular:mainfrom
pmvald:jit-fix-scope

Conversation

@pmvald
Copy link
Copy Markdown
Member

@pmvald pmvald commented Sep 15, 2023

This can unblock the failures in #51415

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pmvald
refactor(core): fix NgModule compilation scope in deps tracker
2d07f14 
Currently deps tracker includes the exported scope of the exported NgModule only in the exported scope of that NgModule. This is in agreement with what AoT does today. But JIT diverges from this behavior by including these exported scopes into the compilation scope as well. Since deps tracker is going to be used for both AoT (local compilation mode) and JIT, the question might be which behavior the deps tracker should follow? Today it follows the AoT one, but it breaks some tests in Google which seem to depend on this behavior of JIT. So it is better to migrate deps tracker to what JIT does. This leads to a wider compilation scope in local compilation compared to full compilations, but it won't break any existing thing.
@pmvald pmvald marked this pull request as ready for review September 15, 2023 01:21
@pullapprove pullapprove bot requested a review from atscott September 15, 2023 01:21
@pmvald pmvald added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release labels Sep 15, 2023
@ngbot ngbot bot added this to the Backlog milestone Sep 15, 2023
@pmvald pmvald requested review from crisbeto and devversion and removed request for atscott September 15, 2023 01:21
devversion
devversion approved these changes Sep 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Capturing this for future reference. This now brings the deps tracker on par with the existing JIT logic (that still is semantically broken compared to how scopes are computed in AOT):

angular/packages/core/src/render3/jit/module.ts

Lines 605 to 610 in 9060640

exportedScope.exported.directives.forEach(entry => {
scopes.compilation.directives.add(entry);
scopes.exported.directives.add(entry);
});
exportedScope.exported.pipes.forEach(entry => {
scopes.compilation.pipes.add(entry);

@pmvald pmvald added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 15, 2023
@devversion devversion removed the request for review from crisbeto September 18, 2023 09:53
@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Sep 18, 2023

This PR was merged into the repository by commit 873e80b.

@pmvald pmvald mentioned this pull request Sep 20, 2023
Closed
14 tasks
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Oct 19, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@pmvald @ChellappanRajan
refactor(core): fix NgModule compilation scope in deps tracker (angul…
d96e49a 
…ar#51791)

Currently deps tracker includes the exported scope of the exported NgModule only in the exported scope of that NgModule. This is in agreement with what AoT does today. But JIT diverges from this behavior by including these exported scopes into the compilation scope as well. Since deps tracker is going to be used for both AoT (local compilation mode) and JIT, the question might be which behavior the deps tracker should follow? Today it follows the AoT one, but it breaks some tests in Google which seem to depend on this behavior of JIT. So it is better to migrate deps tracker to what JIT does. This leads to a wider compilation scope in local compilation compared to full compilations, but it won't break any existing thing.

PR Close angular#51791
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime PullApprove: disable target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@pmvald @pkozlowski-opensource @atscott @devversion