Closed
Conversation
90aff10 to
bee3801
Compare
14 tasks
devversion
added a commit
to devversion/angular
that referenced
this pull request
Aug 28, 2023
…ng, rxjs-interop) Fixes that there was code duplication between the primary entry-point, the testing entry-point and the rxjs-interop entry-point. This code duplication resulted in additional code size (really neglibible here because rxjs-interop did not duplicate large parts of core, and `testing` is not used in production). On the other hand though, the duplication resulted in a subtle JIT dependency tracking issue due to the `depsTracker` no longer being a singleton. This caused test failures as in: angular#51415.
jessicajaniuk
pushed a commit
that referenced
this pull request
Aug 29, 2023
…ng, rxjs-interop) (#51500) Fixes that there was code duplication between the primary entry-point, the testing entry-point and the rxjs-interop entry-point. This code duplication resulted in additional code size (really neglibible here because rxjs-interop did not duplicate large parts of core, and `testing` is not used in production). On the other hand though, the duplication resulted in a subtle JIT dependency tracking issue due to the `depsTracker` no longer being a singleton. This caused test failures as in: #51415. PR Close #51500
bee3801 to
d3b4cde
Compare
devversion
approved these changes
Aug 30, 2023
Member
devversion
left a comment
There was a problem hiding this comment.
LGTM. Original PR was already approved, so we can ignore pull approve
Member
Author
|
Hmm, there is a new target that breaks: link to recent TGP I'll take a look and see if it is related or not. For now lets hold. |
14 tasks
…racker Using verification helpers such as `isComponent` may trigger JIT compilation. Now in some tests such compilation is made purposely to fail, and so in such cases any reference to the `depsTracker.clearScopeCacheFor` method will cause the exception to be thrown earlier than expected which results in teh test failure. Such scenario is the case in the next commit when we enable using the deps tracker in the jit compilation. Note that such failure is only for the framework tests and is a very edge case. The tests in downstream apps will not lead to such scenario of failure at all.
This change simply flip the flag which enables using the deps tracker in JIT compilation (the logic is already implemented in a previous PR). Some tests which depend on the old JIT implementation (e.g., patching the scope info into the type) are modified accordingly.
d3b4cde to
7dda465
Compare
Member
Author
LayZeeDK
pushed a commit
to LayZeeDK/angular__angular
that referenced
this pull request
Sep 20, 2023
…ng, rxjs-interop) (angular#51500) Fixes that there was code duplication between the primary entry-point, the testing entry-point and the rxjs-interop entry-point. This code duplication resulted in additional code size (really neglibible here because rxjs-interop did not duplicate large parts of core, and `testing` is not used in production). On the other hand though, the duplication resulted in a subtle JIT dependency tracking issue due to the `depsTracker` no longer being a singleton. This caused test failures as in: angular#51415. PR Close angular#51500
Contributor
|
This PR was merged into the repository by commit 077534e. |
dylhunn
pushed a commit
that referenced
this pull request
Sep 22, 2023
This change simply flip the flag which enables using the deps tracker in JIT compilation (the logic is already implemented in a previous PR). Some tests which depend on the old JIT implementation (e.g., patching the scope info into the type) are modified accordingly. PR Close #51415
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…racker (angular#51415) Using verification helpers such as `isComponent` may trigger JIT compilation. Now in some tests such compilation is made purposely to fail, and so in such cases any reference to the `depsTracker.clearScopeCacheFor` method will cause the exception to be thrown earlier than expected which results in teh test failure. Such scenario is the case in the next commit when we enable using the deps tracker in the jit compilation. Note that such failure is only for the framework tests and is a very edge case. The tests in downstream apps will not lead to such scenario of failure at all. PR Close angular#51415
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…r#51415) This change simply flip the flag which enables using the deps tracker in JIT compilation (the logic is already implemented in a previous PR). Some tests which depend on the old JIT implementation (e.g., patching the scope info into the type) are modified accordingly. PR Close angular#51415
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the merging of #51500 now this PR passes the aio local test and so it is ready to roll forward.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information