Enable using the runtime dependency tracker in JIT compiler#51293
Closed
pmvald wants to merge 2 commits intoangular:mainfrom
Closed
Enable using the runtime dependency tracker in JIT compiler#51293pmvald wants to merge 2 commits intoangular:mainfrom
pmvald wants to merge 2 commits intoangular:mainfrom
Conversation
…racker Using verification helpers such as `isComponent` may trigger JIT compilation. Now in some tests such compilation is made purposely to fail, and so in such cases any reference to the `depsTracker.clearScopeCacheFor` method will cause the exception to be thrown earlier than expected which results in teh test failure. Such scenario is the case in the next commit when we enable using the deps tracker in the jit compilation. Note that such failure is only for the framework tests and is a very edge case. The tests in downstream apps will not lead to such scenario of failure at all.
This change simply flip the flag which enables using the deps tracker in JIT compilation (the logic is already implemented in a previous PR). Some tests which depend on the old JIT implementation (e.g., patching the scope info into the type) are modified accordingly.
devversion
approved these changes
Aug 9, 2023
Member
|
Caretaker note: TGP is green |
Member
|
This PR was merged into the repository by commit bc55d82. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Aug 14, 2023
This change simply flip the flag which enables using the deps tracker in JIT compilation (the logic is already implemented in a previous PR). Some tests which depend on the old JIT implementation (e.g., patching the scope info into the type) are modified accordingly. PR Close #51293
pkozlowski-opensource
added a commit
to pkozlowski-opensource/angular
that referenced
this pull request
Aug 14, 2023
…angular#51293)" This reverts commit bc55d82.
pkozlowski-opensource
added a commit
to pkozlowski-opensource/angular
that referenced
this pull request
Aug 14, 2023
…n deps tracker (angular#51293)" This reverts commit a9f609e.
pkozlowski-opensource
added a commit
that referenced
this pull request
Aug 14, 2023
pkozlowski-opensource
added a commit
that referenced
this pull request
Aug 14, 2023
Member
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
LayZeeDK
pushed a commit
to LayZeeDK/angular__angular
that referenced
this pull request
Sep 20, 2023
…racker (angular#51293) Using verification helpers such as `isComponent` may trigger JIT compilation. Now in some tests such compilation is made purposely to fail, and so in such cases any reference to the `depsTracker.clearScopeCacheFor` method will cause the exception to be thrown earlier than expected which results in teh test failure. Such scenario is the case in the next commit when we enable using the deps tracker in the jit compilation. Note that such failure is only for the framework tests and is a very edge case. The tests in downstream apps will not lead to such scenario of failure at all. PR Close angular#51293
LayZeeDK
pushed a commit
to LayZeeDK/angular__angular
that referenced
this pull request
Sep 20, 2023
…r#51293) This change simply flip the flag which enables using the deps tracker in JIT compilation (the logic is already implemented in a previous PR). Some tests which depend on the old JIT implementation (e.g., patching the scope info into the type) are modified accordingly. PR Close angular#51293
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…racker (angular#51293) Using verification helpers such as `isComponent` may trigger JIT compilation. Now in some tests such compilation is made purposely to fail, and so in such cases any reference to the `depsTracker.clearScopeCacheFor` method will cause the exception to be thrown earlier than expected which results in teh test failure. Such scenario is the case in the next commit when we enable using the deps tracker in the jit compilation. Note that such failure is only for the framework tests and is a very edge case. The tests in downstream apps will not lead to such scenario of failure at all. PR Close angular#51293
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…r#51293) This change simply flip the flag which enables using the deps tracker in JIT compilation (the logic is already implemented in a previous PR). Some tests which depend on the old JIT implementation (e.g., patching the scope info into the type) are modified accordingly. PR Close angular#51293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simply flips the flag
USE_RUNTIME_DEPS_TRACKER_FOR_JITguarding usage of runtime dependency tracker in the JIT compiler. As a result, the JIT compiler will use the runtime dependency tracker for calculating scopes instead of patching them into the types.This change particularly affects all the Angular tests in g3. Multiple TGPs were run, including this most recent one and all were green.
In the event of any further failure, we can simply revert this PR (or alternatively just set the flag
USE_RUNTIME_DEPS_TRACKER_FOR_JITto false) to resolve the issue.Once this change was confirm not to break anything, the flag
USE_RUNTIME_DEPS_TRACKER_FOR_JITwill be deleted in a separate PR.Also, some internal tests had to be updated as we adopt to use the runtime dependency tracker.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information