refactor(core): enabled using deps tracker in JIT compilation (#51293)

pmvald · pkozlowski-opensource · commit bc55d82eb90b · 2023-08-14T08:57:32.000-07:00
This change simply flip the flag which enables using the deps tracker in JIT compilation (the logic is already implemented in a previous PR). Some tests which depend on the old JIT implementation (e.g., patching the scope info into the type) are modified accordingly. PR Close #51293
diff --git a/packages/core/src/render3/deps_tracker/deps_tracker.ts b/packages/core/src/render3/deps_tracker/deps_tracker.ts
@@ -24,7 +24,7 @@ import {ComponentDependencies, DepsTrackerApi, NgModuleScope, StandaloneComponen
  *
  * @deprecated For migration purposes only, to be removed soon.
  */
-export const USE_RUNTIME_DEPS_TRACKER_FOR_JIT = false;
+export const USE_RUNTIME_DEPS_TRACKER_FOR_JIT = true;
 
 /**
  * An implementation of DepsTrackerApi which will be used for JIT and local compilation.
diff --git a/packages/core/test/test_bed_spec.ts b/packages/core/test/test_bed_spec.ts
@@ -11,6 +11,8 @@ import {TestBed, TestBedImpl} from '@angular/core/testing/src/test_bed';
 import {By} from '@angular/platform-browser';
 import {expect} from '@angular/platform-browser/testing/src/matchers';
 
+import {NgModuleType} from '../src/render3';
+import {depsTracker} from '../src/render3/deps_tracker/deps_tracker';
 import {TEARDOWN_TESTING_MODULE_ON_DESTROY_DEFAULT, THROW_ON_UNKNOWN_ELEMENTS_DEFAULT, THROW_ON_UNKNOWN_PROPERTIES_DEFAULT} from '../testing/src/test_bed_common';
 
 const NAME = new InjectionToken<string>('name');
@@ -1628,19 +1630,28 @@ describe('TestBed', () => {
       expect(cmpDefBeforeReset.pipeDefs().length).toEqual(1);
       expect(cmpDefBeforeReset.directiveDefs().length).toEqual(2);  // directive + component
 
-      const modDefBeforeReset = (SomeModule as any).ɵmod;
-      const transitiveScope = modDefBeforeReset.transitiveCompileScopes.compilation;
-      expect(transitiveScope.pipes.size).toEqual(1);
-      expect(transitiveScope.directives.size).toEqual(2);
+      const scopeBeforeReset = depsTracker.getNgModuleScope(SomeModule as NgModuleType);
+      expect(scopeBeforeReset.compilation.pipes.size).toEqual(1);
+      expect(scopeBeforeReset.compilation.directives.size).toEqual(2);
 
       TestBed.resetTestingModule();
 
       const cmpDefAfterReset = (SomeComponent as any).ɵcmp;
       expect(cmpDefAfterReset.pipeDefs).toBe(null);
       expect(cmpDefAfterReset.directiveDefs).toBe(null);
 
-      const modDefAfterReset = (SomeModule as any).ɵmod;
-      expect(modDefAfterReset.transitiveCompileScopes).toBe(null);
+      const scopeAfterReset = depsTracker.getNgModuleScope(SomeModule as NgModuleType);
+
+      expect(scopeAfterReset).toEqual({
+        compilation: {
+          pipes: new Set(),
+          directives: new Set([SomeComponent]),
+        },
+        exported: {
+          pipes: new Set(),
+          directives: new Set(),
+        }
+      });
     });
 
     it('should cleanup ng defs for classes with no ng annotations (in case of inheritance)', () => {

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ import {ComponentDependencies, DepsTrackerApi, NgModuleScope, StandaloneComponen`
`24`	`24`	`*`
`25`	`25`	`* @deprecated For migration purposes only, to be removed soon.`
`26`	`26`	`*/`
`27`		`-export const USE_RUNTIME_DEPS_TRACKER_FOR_JIT = false;`
	`27`	`+export const USE_RUNTIME_DEPS_TRACKER_FOR_JIT = true;`
`28`	`28`
`29`	`29`	`/**`
`30`	`30`	`* An implementation of DepsTrackerApi which will be used for JIT and local compilation.`