50736 cleanup #51148
Closed
50736 cleanup #51148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add component input binding support for NgComponentOutlet.
905fd81 to
e2aa448
Compare
Member
Author
|
This is a version of #50736 that passes g3 tests (alongside with other minor cleanups). |
14 tasks
AndrewKushnir
approved these changes
Jul 24, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@pkozlowski-opensource LGTM, just a couple non-blocking comments.
dylhunn
approved these changes
Jul 24, 2023
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: fw-common, public-api
AndrewKushnir
approved these changes
Jul 24, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
e2aa448 to
64b14aa
Compare
AndrewKushnir
approved these changes
Jul 25, 2023
Contributor
|
This PR was merged into the repository by commit 29d3581. |
1 task
sunilbaba
pushed a commit
to sunilbaba/angular
that referenced
this pull request
Jul 26, 2023
…et (angular#51148) This commit add component input binding support for NgComponentOutlet. PR Close angular#51148
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…et (angular#51148) This commit add component input binding support for NgComponentOutlet. PR Close angular#51148
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15360