feat(common): add component input binding support for NgComponentOutlet#50736
Closed
HyperLife1119 wants to merge 1 commit intoangular:mainfrom
Closed
feat(common): add component input binding support for NgComponentOutlet#50736HyperLife1119 wants to merge 1 commit intoangular:mainfrom
HyperLife1119 wants to merge 1 commit intoangular:mainfrom
Conversation
14 tasks
336de98 to
0f32953
Compare
This commit add component input binding support for NgComponentOutlet.
0f32953 to
e6b02c4
Compare
Contributor
|
Can we please merge this crucial feature @alxhub |
Closed
Member
|
@HyperLife1119 sorry it took us a bit of time to take care of this PR - some of the internal Google tests were failing and we had to investigate. I do have a changed version (see a fixup commit) in #51148. I'm going to close this PR and work towards landing #51148 instead (the commit will be attributed to you as an author). |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit add component input binding support for NgComponentOutlet.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information