Revert: fix(platform-browser): wait until animation completion before destroying renderer#50857
Closed
AndrewKushnir wants to merge 2 commits intoangular:mainfrom
Closed
Revert: fix(platform-browser): wait until animation completion before destroying renderer#50857AndrewKushnir wants to merge 2 commits intoangular:mainfrom
AndrewKushnir wants to merge 2 commits intoangular:mainfrom
Conversation
This reverts commit d227347.
… destroying renderer (angular#50677)" This reverts commit 2b55103.
alan-agius4
approved these changes
Jun 26, 2023
Contributor
Author
|
Caretaker note: no presubmit is required, since the original change didn't make it into g3. |
Contributor
Author
|
This PR was merged into the repository by commit 452a3e9. |
AndrewKushnir
added a commit
that referenced
this pull request
Jun 26, 2023
AndrewKushnir
added a commit
that referenced
this pull request
Jun 26, 2023
AndrewKushnir
added a commit
that referenced
this pull request
Jun 26, 2023
sunilbaba
pushed a commit
to sunilbaba/angular
that referenced
this pull request
Jul 26, 2023
…" (angular#50857) This reverts commit d227347. PR Close angular#50857
sunilbaba
pushed a commit
to sunilbaba/angular
that referenced
this pull request
Jul 26, 2023
… destroying renderer (angular#50677)" (angular#50857) This reverts commit 2b55103. PR Close angular#50857
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…" (angular#50857) This reverts commit d227347. PR Close angular#50857
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
… destroying renderer (angular#50677)" (angular#50857) This reverts commit 2b55103. PR Close angular#50857
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes from #50677, since there is some extra work that needs to happen in Google's codebase. We'll attempt to land it shortly (later this week).