Revert "fix(platform-browser): wait until animation completion before destroying renderer (#50677)" (#50857)

AndrewKushnir · AndrewKushnir · commit 452a3e9ca0a5 · 2023-06-26T12:18:39.000-07:00
This reverts commit 2b55103. PR Close #50857
diff --git a/packages/animations/browser/src/render/animation_engine_next.ts b/packages/animations/browser/src/render/animation_engine_next.ts
@@ -113,8 +113,4 @@ export class AnimationEngine {
   whenRenderingDone(): Promise<any> {
     return this._transitionEngine.whenRenderingDone();
   }
-
-  afterFlushAnimationsDone(cb: VoidFunction): void {
-    this._transitionEngine.afterFlushAnimationsDone(cb);
-  }
 }
diff --git a/packages/platform-browser/animations/src/animation_renderer.ts b/packages/platform-browser/animations/src/animation_renderer.ts
@@ -138,24 +138,19 @@ export class AnimationRendererFactory implements RendererFactory2 {
 export class BaseAnimationRenderer implements Renderer2 {
   constructor(
       protected namespaceId: string, public delegate: Renderer2, public engine: AnimationEngine,
-      private _onDestroy?: () => void) {}
+      private _onDestroy?: () => void) {
+    this.destroyNode = this.delegate.destroyNode ? (n) => delegate.destroyNode!(n) : null;
+  }
 
   get data() {
     return this.delegate.data;
   }
 
-  destroyNode(node: any): void {
-    this.delegate.destroyNode?.(node);
-  }
+  destroyNode: ((n: any) => void)|null;
 
   destroy(): void {
     this.engine.destroy(this.namespaceId, this.delegate);
-    this.engine.afterFlushAnimationsDone(() => {
-      // Call the renderer destroy method after the animations has finished as otherwise styles will
-      // be removed too early which will cause an unstyled animation.
-      this.delegate.destroy();
-    });
-
+    this.delegate.destroy();
     this._onDestroy?.();
   }
 

Original file line number	Diff line number	Diff line change
`@@ -113,8 +113,4 @@ export class AnimationEngine {`
`113`	`113`	`whenRenderingDone(): Promise<any> {`
`114`	`114`	`return this._transitionEngine.whenRenderingDone();`
`115`	`115`	`}`
`116`		`-`
`117`		`- afterFlushAnimationsDone(cb: VoidFunction): void {`
`118`		`- this._transitionEngine.afterFlushAnimationsDone(cb);`
`119`		`- }`
`120`	`116`	`}`