Skip to content

docs: update docs about prodMode.#49745

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:docs/enableProdMode
Closed

docs: update docs about prodMode.#49745
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:docs/enableProdMode

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Apr 7, 2023

Following #49723, this commit updates the doc to reflect the actual message prompted in the console.

@JeanMeche JeanMeche marked this pull request as ready for review April 7, 2023 10:22
@pullapprove pullapprove bot requested a review from alan-agius4 April 7, 2023 10:22
@ngbot ngbot bot added this to the Backlog milestone Apr 7, 2023
alan-agius4
alan-agius4 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Apr 7, 2023
@alan-agius4
Copy link
Contributor

alan-agius4 commented Apr 7, 2023

Caretaker: the CI failure is unrelated.

@angular angular deleted a comment from ngbot bot Apr 7, 2023
AndrewKushnir
AndrewKushnir reviewed Apr 7, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeanMeche thanks for catching this! 👍

I've left a comment to update the section and avoid mentioning a specific content, so we don't get out of sync in the future. Please let me know what you think.

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Apr 7, 2023
@JeanMeche JeanMeche force-pushed the docs/enableProdMode branch from 027ccfb to 26039b7 Compare April 7, 2023 21:56
@angular-robot angular-robot bot requested a review from alan-agius4 April 7, 2023 21:56
@JeanMeche JeanMeche force-pushed the docs/enableProdMode branch from 26039b7 to a082c11 Compare April 7, 2023 22:09
AndrewKushnir
AndrewKushnir reviewed Apr 7, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just 1 small comment.

@JeanMeche JeanMeche force-pushed the docs/enableProdMode branch 2 times, most recently from cc19c8d to a817ef1 Compare April 7, 2023 23:06
AndrewKushnir
AndrewKushnir reviewed Apr 7, 2023
View reviewed changes
@JeanMeche
docs: update docs about prodMode.
725fbaa 
Following angular#49723, this commit updates the doc to reflect the actual message prompted in the console.
@JeanMeche JeanMeche force-pushed the docs/enableProdMode branch from a817ef1 to 725fbaa Compare April 7, 2023 23:29
AndrewKushnir
AndrewKushnir approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for addressing the feedback! 👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 7, 2023
@ngbot
Copy link

ngbot bot commented Apr 7, 2023

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 7, 2023
@AndrewKushnir AndrewKushnir removed the request for review from alan-agius4 April 7, 2023 23:45
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Apr 10, 2023

This PR was merged into the repository by commit 893eef3.

AndrewKushnir pushed a commit that referenced this pull request Apr 10, 2023
@JeanMeche @AndrewKushnir
docs: update docs about prodMode. (#49745)
e7dd72c 
Following #49723, this commit updates the doc to reflect the actual message prompted in the console.

PR Close #49745
AndrewKushnir pushed a commit that referenced this pull request Apr 10, 2023
@JeanMeche @AndrewKushnir
docs: update docs about prodMode. (#49745)
a605949 
Following #49723, this commit updates the doc to reflect the actual message prompted in the console.

PR Close #49745
@JeanMeche JeanMeche deleted the docs/enableProdMode branch April 10, 2023 20:54
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 11, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@JeanMeche @alan-agius4 @AndrewKushnir