Skip to content

refactor(core): drop a reference to enableProdMode() in a console.log#49723

Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
AndrewKushnir:drop-enable-prod-mode-text
Closed

refactor(core): drop a reference to enableProdMode() in a console.log#49723
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
AndrewKushnir:drop-enable-prod-mode-text

Conversation

@AndrewKushnir
Copy link
Contributor

New ng new apps no longer generate enableProdMode calls when an app is created. The prod mode is enabled via CLI flags (and configuration in the angular.json if needed).

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

  • Yes
  • No

New `ng new` apps no longer generate `enableProdMode` calls when an app is created. The prod mode is enabled via CLI flags (and configuration in the `angular.json` if needed).
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Apr 6, 2023
@ngbot ngbot bot modified the milestone: Backlog Apr 6, 2023
@AndrewKushnir AndrewKushnir requested a review from atscott April 6, 2023 01:43
@alan-agius4 alan-agius4 added target: rc This PR is targeted for the next release-candidate and removed target: major This PR is targeted for the next major release labels Apr 6, 2023
@AndrewKushnir AndrewKushnir removed the request for review from atscott April 6, 2023 15:26
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 6, 2023
@AndrewKushnir
Copy link
Contributor Author

This PR was merged into the repository by commit bf1b5b4.

AndrewKushnir added a commit that referenced this pull request Apr 6, 2023
…og (#49723)

New `ng new` apps no longer generate `enableProdMode` calls when an app is created. The prod mode is enabled via CLI flags (and configuration in the `angular.json` if needed).

PR Close #49723
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 7, 2023
Following angular#49723, this commit updates the doc to reflect the actual message prompted in the console.
AndrewKushnir pushed a commit that referenced this pull request Apr 10, 2023
Following #49723, this commit updates the doc to reflect the actual message prompted in the console.

PR Close #49745
AndrewKushnir pushed a commit that referenced this pull request Apr 10, 2023
Following #49723, this commit updates the doc to reflect the actual message prompted in the console.

PR Close #49745
AndrewKushnir pushed a commit that referenced this pull request Apr 10, 2023
Following #49723, this commit updates the doc to reflect the actual message prompted in the console.

PR Close #49745
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants