Skip to content

build: add --keep_going to components tests.#47958

Closed
dgp1130 wants to merge 1 commit intoangular:mainfrom
dgp1130:keep-going-components
Closed

build: add --keep_going to components tests.#47958
dgp1130 wants to merge 1 commit intoangular:mainfrom
dgp1130:keep-going-components

Conversation

@dgp1130
Copy link
Contributor

@dgp1130 dgp1130 commented Nov 3, 2022

This configures CI to run all the tests and report all the failures instead of aborting after the first one.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Build related changes

What is the current behavior?

Components CI test aborts after the first failure, meaning it requires that first failure to be fixed in the components repo and updated in FW before it will reveal other failures.

Example:

What is the new behavior?

Components CI test now runs all tests as much as it can and reports all the failures.

Does this PR introduce a breaking change?

  • No

Other information

--keep_going flag

This configures CI to run all the tests and report all the failures instead of aborting after the first one.
@dgp1130 dgp1130 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 3, 2022
@dgp1130 dgp1130 requested a review from devversion November 3, 2022 17:47
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 487ad9d.

AndrewKushnir pushed a commit that referenced this pull request Nov 4, 2022
This configures CI to run all the tests and report all the failures instead of aborting after the first one.

PR Close #47958
AndrewKushnir pushed a commit that referenced this pull request Nov 4, 2022
This configures CI to run all the tests and report all the failures instead of aborting after the first one.

PR Close #47958
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2022
trekladyone pushed a commit to trekladyone/angular that referenced this pull request Feb 1, 2023
This configures CI to run all the tests and report all the failures instead of aborting after the first one.

PR Close angular#47958
@dgp1130 dgp1130 deleted the keep-going-components branch April 4, 2023 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants