refactor: replaces aria-hidden with alt=""#25911
Merged
crisbeto merged 1 commit intoangular:mainfrom Nov 3, 2022
Merged
Conversation
An `alt` attribute is required for an upcoming extended diagnostic, and from my understanding is desirable over `aria-hidden` since it maintains `role="img"` while also indicating that the image is decorative.
b24fc8d to
143815e
Compare
crisbeto
reviewed
Nov 2, 2022
...ents-examples/material/autocomplete/autocomplete-overview/autocomplete-overview-example.html
Show resolved
Hide resolved
crisbeto
pushed a commit
that referenced
this pull request
Nov 3, 2022
An `alt` attribute is required for an upcoming extended diagnostic, and from my understanding is desirable over `aria-hidden` since it maintains `role="img"` while also indicating that the image is decorative. (cherry picked from commit b260cb1)
crisbeto
pushed a commit
that referenced
this pull request
Nov 3, 2022
An `alt` attribute is required for an upcoming extended diagnostic, and from my understanding is desirable over `aria-hidden` since it maintains `role="img"` while also indicating that the image is decorative. (cherry picked from commit b260cb1)
dgp1130
added a commit
to dgp1130/angular
that referenced
this pull request
Nov 3, 2022
This updates the components CI test to use the latest commit on their `main` branch (angular/components@a999a52). This is needed to test with angular/components#25911, which fixes an issue introduced by the new extended diagnostic.
5 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
altattribute is required for an upcoming extended diagnostic, and from my understanding is desirable overaria-hiddensince it maintainsrole="img"while also indicating that the image is decorative.See CI failures from: https://app.circleci.com/pipelines/github/angular/angular/52667/workflows/3d58122f-0257-4b79-9ab9-90475590a3f2/jobs/1249004