Skip to content

docs: clarify use of unsubscribe with HttpClient#47127

Closed
bob-watson wants to merge 1 commit intoangular:mainfrom
bob-watson:issue-46542
Closed

docs: clarify use of unsubscribe with HttpClient#47127
bob-watson wants to merge 1 commit intoangular:mainfrom
bob-watson:issue-46542

Conversation

@bob-watson
Copy link
Contributor

fix: #46542

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

When to use unsubscribe() with HttpClient is not clear.

Issue Number: #46542

What is the new behavior?

New text clarifies when to use unsubscribe().

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Replaces PR #47105

@bob-watson bob-watson added action: merge The PR is ready for merge by the caretaker comp: docs labels Aug 11, 2022
@ngbot ngbot bot added this to the Backlog milestone Aug 11, 2022
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: merge The PR is ready for merge by the caretaker doc-topic: dev-guides labels Aug 11, 2022
@bob-watson bob-watson added action: merge The PR is ready for merge by the caretaker aio: preview and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 11, 2022
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker aio: preview labels Aug 11, 2022
@bob-watson bob-watson added action: merge The PR is ready for merge by the caretaker aio: preview and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 11, 2022
@bob-watson bob-watson mentioned this pull request Aug 11, 2022
11 tasks
@bob-watson bob-watson added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: merge The PR is ready for merge by the caretaker labels Aug 11, 2022
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mary-poppins
Copy link

You can preview 1d3738c at https://pr47127-1d3738c.ngbuilds.io/.

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 11, 2022
@mary-poppins
Copy link

You can preview 4569f9f at https://pr47127-4569f9f.ngbuilds.io/.

@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 1329707.

@bob-watson bob-watson deleted the issue-46542 branch August 12, 2022 17:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: clearly explain if/when we need to unsubscribe from HttpClient calls

4 participants