Conversation
|
You can preview d61f1ec at https://pr47105-d61f1ec.ngbuilds.io/. |
josmar-crwdstffng
left a comment
There was a problem hiding this comment.
@ileil
The update looks good, I added one suggestion.
| <div class="alert is-helpful"> | ||
|
|
||
| The [`AsyncPipe`](api/common/AsyncPipe) subscribes and unsubscribes for you automatically. | ||
| You should always unsubscribe from an observable when a component is destroyed. You can use the [`AsyncPipe`](api/common/AsyncPipe) to subscribe to and unsubscribe from an observable automatically. |
There was a problem hiding this comment.
| You should always unsubscribe from an observable when a component is destroyed. You can use the [`AsyncPipe`](api/common/AsyncPipe) to subscribe to and unsubscribe from an observable automatically. | |
| You should always unsubscribe from an observable when a component is destroyed. Use the [`AsyncPipe`](api/common/AsyncPipe) to automatically subscribe to and unsubscribe from an observable. |
| <div class="alert is-helpful"> | ||
|
|
||
| The [`AsyncPipe`](api/common/AsyncPipe) subscribes and unsubscribes for you automatically. | ||
| You should always unsubscribe from an observable when a component is destroyed. You can use the [`AsyncPipe`](api/common/AsyncPipe) to subscribe to and unsubscribe from an observable automatically. |
There was a problem hiding this comment.
I'd like to propose that we drop the sentence about the AsyncPipe. I've looked at the guide at https://angular.io/guide/http and this note is a bit confusing, since it's outside of any relevant context (ideally it should be used in a context of a template and how the subscription is used there).
| You should always unsubscribe from an observable when a component is destroyed. You can use the [`AsyncPipe`](api/common/AsyncPipe) to subscribe to and unsubscribe from an observable automatically. | |
| You should always unsubscribe from an observable when a component is destroyed. |
|
Re-submitted as #47127 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #46542
What is the new behavior?
Under "Starting the request", added the following note:
You should always unsubscribe from an observable when a component is destroyed. You can use the AsyncPipe to subscribe to and unsubscribe from an observable automatically.
Does this PR introduce a breaking change?
Other information