Skip to content

docs: redirect /guide/ivy to the v12 guide#46820

Closed
gkalpak wants to merge 1 commit intoangular:mainfrom
gkalpak:docs-ivy-redirect
Closed

docs: redirect /guide/ivy to the v12 guide#46820
gkalpak wants to merge 1 commit intoangular:mainfrom
gkalpak:docs-ivy-redirect

Conversation

@gkalpak
Copy link
Member

@gkalpak gkalpak commented Jul 13, 2022

Since Ivy is the default since v13, the Ivy guide (that used to live at https://angular.io/guide/ivy) has been removed (see #43860). However, there are certain error messages emitted by the CLI that still point to it.

This commit address the problem by adding a redirect from https://angular.io/guide/ivy to https://v12.angular.io/guide/ivy (which is the last version that includes the guide).

Fixes #46717.

Since Ivy is the default since v13, the Ivy guide (that used to live at
https://angular.io/guide/ivy) has been removed (see angular#43860). However,
there are certain error messages emitted by the CLI that still point to
it.

This commit address the problem by adding a redirect from
https://angular.io/guide/ivy to https://v12.angular.io/guide/ivy (which
is the last version that includes the guide).

Fixes angular#46717
@gkalpak gkalpak added type: bug/fix comp: docs target: patch This PR is targeted for the next patch release labels Jul 13, 2022
@ngbot ngbot bot modified the milestone: Backlog Jul 13, 2022
@mary-poppins
Copy link

You can preview 21d757c at https://pr46820-21d757c.ngbuilds.io/.

@gkalpak gkalpak marked this pull request as ready for review July 13, 2022 15:16
@gkalpak gkalpak added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 13, 2022
@gkalpak gkalpak requested a review from dgp1130 July 13, 2022 15:17
Copy link
Contributor

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks George!

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 13, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit df87f4a.

jessicajaniuk pushed a commit that referenced this pull request Jul 13, 2022
Since Ivy is the default since v13, the Ivy guide (that used to live at
https://angular.io/guide/ivy) has been removed (see #43860). However,
there are certain error messages emitted by the CLI that still point to
it.

This commit address the problem by adding a redirect from
https://angular.io/guide/ivy to https://v12.angular.io/guide/ivy (which
is the last version that includes the guide).

Fixes #46717

PR Close #46820
jessicajaniuk pushed a commit that referenced this pull request Jul 13, 2022
Since Ivy is the default since v13, the Ivy guide (that used to live at
https://angular.io/guide/ivy) has been removed (see #43860). However,
there are certain error messages emitted by the CLI that still point to
it.

This commit address the problem by adding a redirect from
https://angular.io/guide/ivy to https://v12.angular.io/guide/ivy (which
is the last version that includes the guide).

Fixes #46717

PR Close #46820
@gkalpak gkalpak deleted the docs-ivy-redirect branch July 14, 2022 09:25
devversion added a commit to devversion/angular that referenced this pull request Aug 5, 2022
Looks like the `ngsw-config.json` file needs to be updated after a new
redirect being added in: angular#46820.
atscott pushed a commit that referenced this pull request Aug 5, 2022
Looks like the `ngsw-config.json` file needs to be updated after a new
redirect being added in: #46820.

PR Close #47048
atscott pushed a commit that referenced this pull request Aug 5, 2022
Looks like the `ngsw-config.json` file needs to be updated after a new
redirect being added in: #46820.

PR Close #47048
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ivy URL shows page not found

4 participants