Skip to content

docs: remove Ivy-specific guides#43860

Closed
dgp1130 wants to merge 1 commit intoangular:masterfrom
dgp1130:aio-ivy
Closed

docs: remove Ivy-specific guides#43860
dgp1130 wants to merge 1 commit intoangular:masterfrom
dgp1130:aio-ivy

Conversation

@dgp1130
Copy link
Contributor

@dgp1130 dgp1130 commented Oct 15, 2021

Ivy is the only supported rendering engine in v13, so there is no need to document the concept. Everything in Angular is Ivy. This starts the removal process by deleting Ivy-specific guides and references to them. It also updates the glossary to be more clear that Ivy is the current rendering engine while View Engine is simply a historical note.

This does not attempt to fully remove all references to "Ivy" or "View Engine", that will likely be a more involved clean up process.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

AIO has Ivy specific guides and pages which are no longer needed in v13 where Ivy is the only supported rendering engine.

What is the new behavior?

These guides and references to them are removed. This PR does not attempt to remove all references to Ivy and View Engine (though we should definitely do that). This is just a starting point for the removal and to help us be more clear that View Engine is not supported in v13.

Ivy is the only supported rendering engine in v13, so there is no need to document the concept. Everything in Angular is Ivy. This starts the removal process by deleting Ivy-specific guides and references to them. It also updates the glossary to be more clear that Ivy is the current rendering engine while View Engine is simply a historical note.

This does not attempt to fully remove all references to "Ivy" or "View Engine", that will likely be a more involved clean up process.
@dgp1130 dgp1130 added the target: rc This PR is targeted for the next release-candidate label Oct 15, 2021
@google-cla google-cla bot added the cla: yes label Oct 15, 2021
@pullapprove pullapprove bot requested a review from AndrewKushnir October 15, 2021 19:20
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you

Reviewed-for: global-docs-approvers

@pullapprove pullapprove bot requested a review from IgorMinar October 15, 2021 19:46
Copy link
Contributor

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💠

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. how come my previous approval didn't work? let's try again..

Reviewed-for: global-docs-approvers

@pullapprove pullapprove bot requested a review from IgorMinar October 15, 2021 20:02
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah.. one more try..

Reviewed-for: global-approvers

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup Doug!

@ngbot ngbot bot added this to the Backlog milestone Oct 20, 2021
Copy link
Contributor

@aikithoughts aikithoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Reviewed-for: global-docs-approvers

@dgp1130 dgp1130 added the action: merge The PR is ready for merge by the caretaker label Oct 21, 2021
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 4ed8dc8.

jessicajaniuk pushed a commit that referenced this pull request Oct 21, 2021
Ivy is the only supported rendering engine in v13, so there is no need to document the concept. Everything in Angular is Ivy. This starts the removal process by deleting Ivy-specific guides and references to them. It also updates the glossary to be more clear that Ivy is the current rendering engine while View Engine is simply a historical note.

This does not attempt to fully remove all references to "Ivy" or "View Engine", that will likely be a more involved clean up process.

PR Close #43860
@dgp1130 dgp1130 deleted the aio-ivy branch November 2, 2021 20:46
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants