fix(forms): Make some fixes to typed forms API and docs.#46023
fix(forms): Make some fixes to typed forms API and docs.#46023dylhunn wants to merge 2 commits intoangular:mainfrom
Conversation
AndrewKushnir
left a comment
There was a problem hiding this comment.
@dylhunn thanks for the updates 👍 I've left one minor comment.
I also think that we should probably have 2 separate commits in this PR: one is a revert of the previous commit that made the Value and RawValue public and the second one is the docs update (and make it docs(forms): ..., so it's not included in the changeog). That should help the tooling to ensure that the initial "feat(forms)" commit is not present in a changelog (or at least that'd be visible to a caretaker would would assemble the changelog for v14.0.0 release).
2dcd14c to
9e19f64
Compare
AndrewKushnir
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback 👍
Could you please also change the fix(forms): -> docs(forms): in the commit message?
* `FormRecord` jsdocs should now appear on a.io
* The `{@see foo#bar}` syntax previously did not work, and has been replace with backticks
…PI." As per discussion on #fw-forms, this reverts angular#45978 (although the more in-depth comments were kept).
|
Done, thanks! |
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
|
merge-assistance: presubmit failures are unrelated |
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
|
This PR was merged into the repository by commit 038ba8a. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
FormRecordJSDoc should now appear on a.io{@see foo#bar}syntax previously did not work, and has been replace with backticks