fix(forms): Value and RawValue should be part of the public API.#45978
Closed
dylhunn wants to merge 1 commit intoangular:mainfrom
Closed
fix(forms): Value and RawValue should be part of the public API.#45978dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn wants to merge 1 commit intoangular:mainfrom
Conversation
AndrewKushnir
approved these changes
May 13, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Looks good (just a couple minor docs-related comments) 👍
jessicajaniuk
previously approved these changes
May 13, 2022
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
AndrewKushnir
previously approved these changes
May 13, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@givebk-bot !donate @dylhunn $1 thanks for your PR! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Consider a typed group for storing contact information:
```
declare interface ContactControls {
name: FormControl<string|null>;
}
contactForm: FormGroup<ContactControls> = ...;
saveForm(form: FormGroup<ContactControls>) {
service.newContact(contactForm.value);
}
```
What should be the type of `newContact`? The answer, of course, is the value type:
```
declare interface Contact {
name: string|null;
}
class ContactService {
newContact(c: Contact) {}
}
```
This is quite redundant, and therefore, we should allow the value type to be generated automatically. We already have the helper types to do this -- we just need to document and export them. Then, this becomes possible:
```
class ContactService {
newContact(c: RawValue<FormGroup<ContactControls>>) {}
}
```
pkozlowski-opensource
approved these changes
May 16, 2022
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
Contributor
Author
|
merge-assistance: this PR has the needed approvals (see above), and should be ready to merge. |
jessicajaniuk
approved these changes
May 16, 2022
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit dba6a60. |
jessicajaniuk
pushed a commit
that referenced
this pull request
May 16, 2022
) Consider a typed group for storing contact information: ``` declare interface ContactControls { name: FormControl<string|null>; } contactForm: FormGroup<ContactControls> = ...; saveForm(form: FormGroup<ContactControls>) { service.newContact(contactForm.value); } ``` What should be the type of `newContact`? The answer, of course, is the value type: ``` declare interface Contact { name: string|null; } class ContactService { newContact(c: Contact) {} } ``` This is quite redundant, and therefore, we should allow the value type to be generated automatically. We already have the helper types to do this -- we just need to document and export them. Then, this becomes possible: ``` class ContactService { newContact(c: RawValue<FormGroup<ContactControls>>) {} } ``` PR Close #45978
dylhunn
added a commit
to dylhunn/angular
that referenced
this pull request
May 17, 2022
…PI." As per discussion on #fw-forms, this reverts angular#45978 (although the more in-depth comments were kept).
Contributor
|
@simonmumenthaler We merged it prematurely. It needs some additional design before we can land it and probably won't land until 14.1. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider a typed group for storing contact information:
What should be the type of
newContact? The answer, of course, is the value type:This is quite redundant, and therefore, we should allow the value type to be generated automatically. We already have the helper types to do this -- we just need to document and export them. Then, this becomes possible:
You can even create an alias, which produces the same type as
Contactabove:This PR was filed in response to a user issue report during
14.0.0-rc.0.