refactor(core): avoid code duplication in standalone-related logic#45949
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): avoid code duplication in standalone-related logic#45949AndrewKushnir wants to merge 1 commit intoangular:mainfrom
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
This commit updates the standalone-related logic to address the feedback from previous code reviews (specifically: angular#45687 (comment)).
dfe09ec to
a2f6e6d
Compare
pkozlowski-opensource
approved these changes
May 11, 2022
| standalone: componentDefinition.standalone === true, | ||
| dependencies: | ||
| componentDefinition.standalone === true && componentDefinition.dependencies || null, | ||
| standalone, |
There was a problem hiding this comment.
nit: could we use a long-form here (standalone: standalone)? It is easy to break things with a rename and it looks inconsistent with the existing code.
pkozlowski-opensource
approved these changes
May 16, 2022
Contributor
|
This PR was merged into the repository by commit ca04ece. |
jessicajaniuk
pushed a commit
that referenced
this pull request
May 16, 2022
…45949) This commit updates the standalone-related logic to address the feedback from previous code reviews (specifically: #45687 (comment)). PR Close #45949
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the standalone-related logic to address the feedback from previous code reviews (specifically: #45687 (comment)).
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?