refactor(core): avoid code duplication in standalone-related logic (#45949)

AndrewKushnir · thePunderWoman · commit ca04ecedec42 · 2022-05-16T10:05:23.000-07:00
This commit updates the standalone-related logic to address the feedback from previous code reviews (specifically: #45687 (comment)). PR Close #45949
diff --git a/packages/core/src/render3/definition.ts b/packages/core/src/render3/definition.ts
@@ -288,6 +288,7 @@ export function ɵɵdefineComponent<T>(componentDefinition: {
     (typeof ngDevMode === 'undefined' || ngDevMode) && initNgDevMode();
 
     const type = componentDefinition.type;
+    const standalone = componentDefinition.standalone === true;
     const declaredInputs: {[key: string]: string} = {} as any;
     const def: Mutable<ComponentDef<any>, keyof ComponentDef<any>> = {
       type: type,
@@ -309,9 +310,8 @@ export function ɵɵdefineComponent<T>(componentDefinition: {
       onPush: componentDefinition.changeDetection === ChangeDetectionStrategy.OnPush,
       directiveDefs: null!,  // assigned in noSideEffects
       pipeDefs: null!,       // assigned in noSideEffects
-      standalone: componentDefinition.standalone === true,
-      dependencies:
-          componentDefinition.standalone === true && componentDefinition.dependencies || null,
+      standalone,
+      dependencies: standalone && componentDefinition.dependencies || null,
       getStandaloneInjector: null,
       selectors: componentDefinition.selectors || EMPTY_ARRAY,
       viewQuery: componentDefinition.viewQuery || null,
