fix(docs-infra): include tslib into SystemJS config in upgrade-module example app#45706
Closed
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Closed
fix(docs-infra): include tslib into SystemJS config in upgrade-module example app#45706AndrewKushnir wants to merge 1 commit intoangular:masterfrom
tslib into SystemJS config in upgrade-module example app#45706AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Conversation
…ule` example app This commit updates the SystemJS for one of the example apps (the `upgrade-module` one) to include a resolution rule for the `tslib`. This is needed in case `tslib` is referenced from the framework code (for example in case of downleveling of some operators). This makes it consistent with other example app configs.
Contributor
|
This PR was merged into the repository by commit 9292953. |
atscott
pushed a commit
that referenced
this pull request
Apr 21, 2022
…ule` example app (#45706) This commit updates the SystemJS for one of the example apps (the `upgrade-module` one) to include a resolution rule for the `tslib`. This is needed in case `tslib` is referenced from the framework code (for example in case of downleveling of some operators). This makes it consistent with other example app configs. PR Close #45706
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the SystemJS for one of the example apps (the
upgrade-moduleone) to include a resolution rule for thetslib. This is needed in casetslibis referenced from the framework code (for example in case of downleveling of some operators). This makes it consistent with other example app configs.This issue was causing Protractor errors in the PR #45674 when native async/await were used in the code and downlevelled to use
__awaiterhelper fromtslib.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?