feat(core): add bootstrapApplication function#45674
feat(core): add bootstrapApplication function#45674AndrewKushnir wants to merge 2 commits intoangular:masterfrom
bootstrapApplication function#45674Conversation
d34f052 to
ae85c42
Compare
There was a problem hiding this comment.
Question: is this interface something that can / should be shared across platforms? Would it makes sense to move it to core and export from here?
There was a problem hiding this comment.
Currently the code is structured as follows:
- the
@angular/corehas an internal implementation of thebootstrapApplicationfunction, which has more fields than a public version of thebootstrapApplication(for ex. it has a list of platform providers) - the
@angular/platform-browseruses an internalbootstrapApplicationfunction and exposes a function with a slightly different interface (the public version) as a public API
My thinking is that the public function and supported interfaces should be co-located (i.e. located in @angular/platform-browser) as the ApplicationConfig might potentially vary depending on a platform (for ex. there might be more configuration required for SSR, etc).
There was a problem hiding this comment.
We probably do want to share ApplicationConfig across platforms, but we'll probably do that if/when we move bootstrapApplication to core.
6ff45bd to
eb69b66
Compare
eb69b66 to
c0bd746
Compare
c568c5e to
4e4c589
Compare
alxhub
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api,size-tracking
There was a problem hiding this comment.
We probably do want to share ApplicationConfig across platforms, but we'll probably do that if/when we move bootstrapApplication to core.
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
This commit implements the `bootstrapApplication` function that allows bootstrapping an application and pass a standalone component as a root component.
This commit adds 2 integration apps to verify the `bootstrapApplication` API behavior as well as keep track of the bundle size and retained symbols (tree-shaking).
4e4c589 to
b60f34c
Compare
|
Merge-assistance: PR is ready for merge. |
|
This PR was merged into the repository by commit 3e46a42. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Note: this is a draft as it relies on some missing functionality (such as a standalone injector service and other standalone components public API).
This commit implements the
bootstrapApplicationfunction that allows bootstrapping an application and pass a standalone component as a root component.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?