Conversation
|
Please see this link for more information about Google's response: https://blog.google/inside-google/company-announcements/helping-ukraine/ |
|
As @dylhunn mentioned Google supports Ukraine. We'll be happy to do our part of this by adding a banner to angular.io. @zverbeta, could you change the URL to point to https://www.google.org/ukraine-relief/? Additionally, please make sure you're following the contribution guide. You will have to update the commit message. Thanks! |
|
You can preview ffb8718 at https://pr45376-ffb8718.ngbuilds.io/. |
|
You can preview f8db95b at https://pr45376-f8db95b.ngbuilds.io/. |
|
You can preview cc7894f at https://pr45376-cc7894f.ngbuilds.io/. |
|
You can preview 77faae9 at https://pr45376-77faae9.ngbuilds.io/. |
|
@zverbeta would you update the styles of the banner a little? I like the design React uses for their banner. Once we change the styles I will review and we can merge. |
|
You can preview c741810 at https://pr45376-c741810.ngbuilds.io/. |
|
You can preview 8a8f87e at https://pr45376-8a8f87e.ngbuilds.io/. |
|
@mgechev I updated styles, ✔️please |
aio/src/app/app.component.html
Outdated
There was a problem hiding this comment.
An SVG is better for systems don't not have a color emoji font installed. IIRC, openSUSE doesn't have one installed by default, and there might be other OSes.
The flag of Ukraine is half #0057b7 and #ffd700, assuming we don't go with the legacy Websafe color, and an aspect ratio of 3 by 2.
Here's one that I've just created, using the HEX colors mentioned on the (locked) wikipedia page:
<svg height="24" width="24" version="1.1" viewBox="0 0 240 240" xmlns="http://www.w3.org/2000/svg">
<rect fill="#0057b7" height="72" width="240" x="0" y="48"/>
<rect fill="#ffd700" height="72" width="240" x="0" y="120"/>
</svg>Or you could use the one from Wikipedia, which uses a different set of HEX colors, because they've been converted into HEX from a different color scheme.
|
Can we also address this comment? Thank you for the contribution and the patience :) #45376 (comment) |
|
@zverbeta approved! ✅ There's a merge conflict that you'll have to resolve before we're able to merge. |
|
@zverbeta Happy to merge this, please tag me once the merge conflict is resolved and I will merge it. |
|
You can preview 827c6e8 at https://pr45376-827c6e8.ngbuilds.io/. |
|
@dylhunn I resolved merge conflicts, but test_aio_local exceeded size limit. Could you suggest any ideas why that happend |
|
@zverbeta I think that's because we are adding new code, you can open |
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: size-tracking
|
You can preview 635b716 at https://pr45376-635b716.ngbuilds.io/. |
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: size-tracking
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
This PR was merged into the repository by commit 8e09445. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Support Ukraine
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information