Skip to content

docs: patch port of #45376#45473

Closed
dylhunn wants to merge 1 commit intoangular:13.3.xfrom
dylhunn:ukraine-patch-port
Closed

docs: patch port of #45376#45473
dylhunn wants to merge 1 commit intoangular:13.3.xfrom
dylhunn:ukraine-patch-port

Conversation

@dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Mar 29, 2022

#45376 had merge conflicts with 13.3.x and needed a patch port. See #45376 for approvals, this diff is identical.

@dylhunn dylhunn added the target: patch This PR is targeted for the next patch release label Mar 29, 2022
@dylhunn dylhunn changed the base branch from master to 13.3.x March 29, 2022 22:34
@dylhunn dylhunn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 29, 2022
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Mar 29, 2022
@ngbot
Copy link

ngbot bot commented Mar 29, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: setup" is failing
    pending status "google3" is pending
    pending status "pullapprove" is pending
    pending missing required status "ci/circleci: build"
    pending missing required status "ci/circleci: lint"
    pending missing required status "ci/angular: size"
    pending 7 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@dylhunn
Copy link
Contributor Author

dylhunn commented Mar 29, 2022

This PR was merged into the repository by commit 6e45777.

@dylhunn dylhunn closed this Mar 29, 2022
dylhunn added a commit that referenced this pull request Mar 29, 2022
JoostK added a commit to JoostK/angular that referenced this pull request Mar 30, 2022
The backport in angular#45473 introduced a change in payload sizes that is not met on
the 13.3.x branch, this commit corrects this issue.
dylhunn pushed a commit that referenced this pull request Mar 30, 2022
The backport in #45473 introduced a change in payload sizes that is not met on
the 13.3.x branch, this commit corrects this issue.

PR Close #45480
@dylhunn dylhunn deleted the ukraine-patch-port branch April 12, 2022 17:46
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants