Skip to content

fix(language-service): Prioritize Angular-specific completions over DOM completions#45293

Closed
atscott wants to merge 1 commit intoangular:masterfrom
atscott:prioritizeAngularCompletions
Closed

fix(language-service): Prioritize Angular-specific completions over DOM completions#45293
atscott wants to merge 1 commit intoangular:masterfrom
atscott:prioritizeAngularCompletions

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Mar 8, 2022

When authoring Angular templates, developers are likely to be most interested in
the current Directive/Component inputs and outputs, then potential
attributes which would match other directives to the element,
and lastly the plethora of DOM events and attributes.

This change ensures that Angular-specific information appears above DOM
information by prepending the first printable ASCII characters to the
sort text.

Fixes angular/vscode-ng-language-service#1537

…OM completions

When authoring Angular templates, developers are likely to be most interested in
the current Directive/Component inputs and outputs, then potential
attributes which would match other directives to the element,
and lastly the plethora of DOM events and attributes.

This change ensures that Angular-specific information appears above DOM
information by prepending the first printable ASCII characters to the
sort text.

Fixes angular/vscode-ng-language-service#1537
@atscott atscott added action: review The PR is still awaiting reviews from at least one requested reviewer area: language-service Issues related to Angular's VS Code language service target: patch This PR is targeted for the next patch release labels Mar 8, 2022
@ngbot ngbot bot modified the milestone: Backlog Mar 8, 2022
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 8, 2022
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit be220fa.

AndrewKushnir pushed a commit that referenced this pull request Mar 8, 2022
…OM completions (#45293)

When authoring Angular templates, developers are likely to be most interested in
the current Directive/Component inputs and outputs, then potential
attributes which would match other directives to the element,
and lastly the plethora of DOM events and attributes.

This change ensures that Angular-specific information appears above DOM
information by prepending the first printable ASCII characters to the
sort text.

Fixes angular/vscode-ng-language-service#1537

PR Close #45293
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 18, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.2.5/13.2.6) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.2.5/13.2.6) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.2.5/13.2.6) |
| [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.2.5/13.2.6) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.2.5/13.2.6) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.2.5/13.2.6) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.2.5/13.2.6) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.2.5/13.2.6) |
| [@angular/router](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2frouter/13.2.5/13.2.6) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v13.2.6`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1326-2022-03-09)

[Compare Source](angular/angular@13.2.5...13.2.6)

##### compiler

| Commit | Type | Description |
| -- | -- | -- |
| [6efa366e2c](angular/angular@6efa366) | fix | compute correct offsets when interpolations have HTML entities ([#&#8203;44811](angular/angular#44811)) |

##### language-service

| Commit | Type | Description |
| -- | -- | -- |
| [9bce9ce89e](angular/angular@9bce9ce) | fix | Prioritize Angular-specific completions over DOM completions ([#&#8203;45293](angular/angular#45293)) |

##### service-worker

| Commit | Type | Description |
| -- | -- | -- |
| [cff1c5622f](angular/angular@cff1c56) | fix | file system hash in batch of 500 elements ([#&#8203;45262](angular/angular#45262)) |

#### Special Thanks

Andrew Scott, Anner Visser, Aristeidis Bampakos, JiaLiPassion, Joey Perrott, Kristiyan Kostadinov, Luca, Mladen Jakovljević, Paul Gschwendtner, Srikanth Kolli and nanda18

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1211
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autocomplete: Sort component properties by relevance

3 participants