Skip to content

fix(service-worker): file system hash in batch of 500 elements#45262

Closed
LucaBruni wants to merge 1 commit intoangular:masterfrom
LucaBruni:fix-service-worker-generation
Closed

fix(service-worker): file system hash in batch of 500 elements#45262
LucaBruni wants to merge 1 commit intoangular:masterfrom
LucaBruni:fix-service-worker-generation

Conversation

@LucaBruni
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #45133

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented Mar 4, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@pullapprove pullapprove bot requested a review from gkalpak March 4, 2022 12:02
@LucaBruni LucaBruni force-pushed the fix-service-worker-generation branch from 319ac8d to f52221d Compare March 4, 2022 14:29
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @LucaBruni 👍
I left a couple of minor comments - otherwise this looks good 🚀

@gkalpak gkalpak added area: service-worker Issues related to the @angular/service-worker package target: patch This PR is targeted for the next patch release type: bug/fix labels Mar 4, 2022
@ngbot ngbot bot modified the milestone: Backlog Mar 4, 2022
@gkalpak
Copy link
Member

gkalpak commented Mar 4, 2022

Also, please squash the commits into one.

@LucaBruni LucaBruni force-pushed the fix-service-worker-generation branch from f52221d to 2440e8b Compare March 7, 2022 10:21
@AndrewKushnir AndrewKushnir requested a review from gkalpak March 7, 2022 22:36
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for making the changes, @LucaBruni 👍
One last comment and this should be good to go 🚀

@LucaBruni LucaBruni force-pushed the fix-service-worker-generation branch from 2440e8b to 663c7e7 Compare March 8, 2022 13:58
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkalpak gkalpak changed the title Fix service worker generation fix(service-worker): file system hash in batch of 500 elements Mar 8, 2022
@gkalpak gkalpak added the action: merge The PR is ready for merge by the caretaker label Mar 8, 2022
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 3ecf930.

AndrewKushnir pushed a commit that referenced this pull request Mar 8, 2022
Add file system concurrency hash test

Fixes #45133
PR Close #45262
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 18, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.2.5/13.2.6) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.2.5/13.2.6) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.2.5/13.2.6) |
| [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.2.5/13.2.6) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.2.5/13.2.6) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.2.5/13.2.6) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.2.5/13.2.6) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.2.5/13.2.6) |
| [@angular/router](https://github.com/angular/angular) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2frouter/13.2.5/13.2.6) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v13.2.6`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1326-2022-03-09)

[Compare Source](angular/angular@13.2.5...13.2.6)

##### compiler

| Commit | Type | Description |
| -- | -- | -- |
| [6efa366e2c](angular/angular@6efa366) | fix | compute correct offsets when interpolations have HTML entities ([#&#8203;44811](angular/angular#44811)) |

##### language-service

| Commit | Type | Description |
| -- | -- | -- |
| [9bce9ce89e](angular/angular@9bce9ce) | fix | Prioritize Angular-specific completions over DOM completions ([#&#8203;45293](angular/angular#45293)) |

##### service-worker

| Commit | Type | Description |
| -- | -- | -- |
| [cff1c5622f](angular/angular@cff1c56) | fix | file system hash in batch of 500 elements ([#&#8203;45262](angular/angular#45262)) |

#### Special Thanks

Andrew Scott, Anner Visser, Aristeidis Bampakos, JiaLiPassion, Joey Perrott, Kristiyan Kostadinov, Luca, Mladen Jakovljević, Paul Gschwendtner, Srikanth Kolli and nanda18

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1211
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: service-worker Issues related to the @angular/service-worker package target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants