perf(animations): made errors in the animations package tree shakeable by jessicajaniuk · Pull Request #45004 · angular/angular

jessicajaniuk · 2022-02-08T00:05:41Z

This moves all the error strings into exported functions that can be tree shaken away.

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Errors in the animations code base are just defined all inline and affect bundle size.

Issue Number: N/A

What is the new behavior?

Errors are centralized in one file and should be tree shakeable.

Does this PR introduce a breaking change?

Yes
No

Other information

packages/animations/browser/src/errors.ts

AndrewKushnir

LGTM, just some minor comments.

I think we'd need to add golden files for the error codes as well, see #44677, so that they are a part of the public API.

AndrewKushnir · 2022-02-08T20:28:58Z

goldens/size-tracking/integration-payloads.json

packages/animations/browser/src/dsl/animation_transition_expr.ts

packages/animations/browser/src/errors.ts

packages/animations/browser/src/render/animation_engine_next.ts

packages/animations/browser/src/render/shared.ts

atscott

reviewed-for: size-tracking

alxhub · 2022-02-08T23:22:50Z

goldens/public-api/animations/errors.md

Is there value in tracking these signatures from a public API perspective?

In other "error" API tests that we have, we only really care about the error codes, not the helper functions that create those errors.

I think I could move the helper functions and only have the codes exposed.

They are now moved.

This moves all the error strings into exported functions that can be tree shaken away.

alxhub

Reviewed-for: public-api

atscott

reviewed-for: public-api

AndrewKushnir

Reviewed-for: public-api

AndrewKushnir

Reviewed-for: size-tracking

alxhub · 2022-02-09T19:42:57Z

This PR doesn't apply cleanly to 13.2.x. Marking it as master-only - please open a separate PR against the patch branch if desired.

alxhub · 2022-02-09T19:43:44Z

This PR was merged into the repository by commit 4c778cd.

angular-automatic-lock-bot · 2022-03-12T16:08:53Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

angular#45004) This moves all the error strings into exported functions that can be tree shaken away. PR Close angular#45004

jessicajaniuk added the area: animations label Feb 8, 2022

ngbot bot added this to the Backlog milestone Feb 8, 2022

jessicajaniuk force-pushed the error-tree-shake branch 5 times, most recently from d497cfc to 4ccac76 Compare February 8, 2022 01:50

AndrewKushnir reviewed Feb 8, 2022

View reviewed changes

packages/animations/browser/src/errors.ts Outdated Show resolved Hide resolved

jessicajaniuk force-pushed the error-tree-shake branch from 4ccac76 to 7e6b24d Compare February 8, 2022 17:44

pullapprove bot requested review from AndrewKushnir, atscott, dylhunn and jelbourn February 8, 2022 17:44

jessicajaniuk force-pushed the error-tree-shake branch 4 times, most recently from ae1e194 to 56faf8a Compare February 8, 2022 19:29

jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Feb 8, 2022

AndrewKushnir reviewed Feb 8, 2022

View reviewed changes

pullapprove bot requested a review from alxhub February 8, 2022 20:37

atscott approved these changes Feb 8, 2022

View reviewed changes

pullapprove bot requested a review from AndrewKushnir February 8, 2022 21:38

jessicajaniuk force-pushed the error-tree-shake branch 3 times, most recently from ff21856 to d34b088 Compare February 8, 2022 22:32

alxhub reviewed Feb 8, 2022

View reviewed changes

pullapprove bot requested a review from atscott February 8, 2022 23:23

jessicajaniuk force-pushed the error-tree-shake branch from d34b088 to 05b34c7 Compare February 8, 2022 23:38

perf(animations): made errors in the animations package tree shakeable

0d8a2aa

This moves all the error strings into exported functions that can be tree shaken away.

jessicajaniuk force-pushed the error-tree-shake branch from 05b34c7 to 0d8a2aa Compare February 8, 2022 23:46

alxhub approved these changes Feb 9, 2022

View reviewed changes

atscott approved these changes Feb 9, 2022

View reviewed changes

AndrewKushnir approved these changes Feb 9, 2022

View reviewed changes

pullapprove bot requested review from AndrewKushnir and alxhub February 9, 2022 01:32

AndrewKushnir approved these changes Feb 9, 2022

View reviewed changes

jessicajaniuk removed request for alxhub, dylhunn and jelbourn February 9, 2022 01:33

jessicajaniuk added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 9, 2022

alxhub added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 9, 2022

alxhub closed this in 4c778cd Feb 9, 2022

jessicajaniuk mentioned this pull request Feb 14, 2022

[13.2.x]: made errors in the animations package tree shakeable, patch port of #45004 #45079

Closed

14 tasks

angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 12, 2022

jessicajaniuk deleted the error-tree-shake branch January 27, 2023 16:41

Conversation

jessicajaniuk commented Feb 8, 2022

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atscott left a comment

Choose a reason for hiding this comment

Uh oh!

alxhub Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

jessicajaniuk Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

jessicajaniuk Feb 9, 2022

Choose a reason for hiding this comment

Uh oh!

alxhub left a comment

Choose a reason for hiding this comment

Uh oh!

atscott left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

alxhub commented Feb 9, 2022

Uh oh!

alxhub commented Feb 9, 2022

Uh oh!

angular-automatic-lock-bot bot commented Mar 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants